Exclude border from overflow scroller in sticky constraints.

Exclude border from overflow scroller in sticky constraints.

BUG=664373
TEST=LayoutBoxModelObjectTest.StickyPositionConstraints, LayoutBoxModelObjectTest.StickyPositionContainerIsScroller

Committed: https://crrev.com/177abac624e0be0d9d94c7cc1392f9beddf97c87
Cr-Commit-Position: refs/heads/master@{#431982}

[flackr, 2016-11-11 02:39:24]

flackr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[flackr, 2016-11-11 02:39:25]

Hey,

I found out that we were incorrectly offsetting sticky position elements by the
border of the scroller. Please take a look at this patch to fix it. I've added
borders to the two main unit tests which verify the sticky position constraints.

Thanks,
Rob

[chrishtr, 2016-11-12 00:17:20]

lgtm

Cool.

https://codereview.chromium.org/2494933002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp (right):

https://codereview.chromium.org/2494933002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp:66: // The
sticky constraining rect also doesn't include the border offset.
Please add a vertical-rl example also.

[flackr, 2016-11-14 14:50:14]

https://codereview.chromium.org/2494933002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp (right):

https://codereview.chromium.org/2494933002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp:66: // The
sticky constraining rect also doesn't include the border offset.
On 2016/11/12 at 00:17:20, chrishtr wrote:
> Please add a vertical-rl example also.

Done.

[flackr, 2016-11-14 14:50:18]

The CQ bit was checked by flackr@chromium.org

[flackr, 2016-11-14 14:50:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2494933002/#ps20001
(title: "Add RTL sticky constraint test.")

[commit-bot: I haz the power, 2016-11-14 14:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:46:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-14 23:58:10]

Description was changed from

==========
Exclude border from overflow scroller in sticky constraints.

BUG=664373
TEST=LayoutBoxModelObjectTest.StickyPositionConstraints,
LayoutBoxModelObjectTest.StickyPositionContainerIsScroller
==========

to

==========
Exclude border from overflow scroller in sticky constraints.

BUG=664373
TEST=LayoutBoxModelObjectTest.StickyPositionConstraints,
LayoutBoxModelObjectTest.StickyPositionContainerIsScroller

Committed: https://crrev.com/177abac624e0be0d9d94c7cc1392f9beddf97c87
Cr-Commit-Position: refs/heads/master@{#431982}
==========

[commit-bot: I haz the power, 2016-11-14 23:58:12]

Patchset 2 (id:??) landed as
https://crrev.com/177abac624e0be0d9d94c7cc1392f9beddf97c87
Cr-Commit-Position: refs/heads/master@{#431982}