Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 249493002: Reskins the Compact and System VK to look closer to the IME VK. (Closed)

Created:
6 years, 8 months ago by rsadam
Modified:
6 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reskins the Compact and System VK to look closer to the IME VK. Since some of the new icon assets are missing, continue to use the old assets (with color changed) for consistency. BUG=364468 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265782

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed background-image to background-color. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -106 lines) Patch
M ui/keyboard/resources/elements/kb-key.html View 3 chunks +15 lines, -24 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.html View 1 chunk +1 line, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-shift-key.html View 1 chunk +3 lines, -7 lines 0 comments Download
M ui/keyboard/resources/images/back.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/backspace.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/down.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/hide-keyboard.svg View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/resources/images/left.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/return.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/right.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/search.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/shift.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/shift-filled.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/tab.svg View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/resources/images/up.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/main.css View 1 2 chunks +9 lines, -59 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rsadam
Biao PTAL!
6 years, 8 months ago (2014-04-23 14:56:01 UTC) #1
bshe
https://codereview.chromium.org/249493002/diff/1/ui/keyboard/resources/main.css File ui/keyboard/resources/main.css (right): https://codereview.chromium.org/249493002/diff/1/ui/keyboard/resources/main.css#newcode35 ui/keyboard/resources/main.css:35: -webkit-linear-gradient(rgba(0, 0, 255,0.5), rgba(0, 0, 255, 0.5)); Do you ...
6 years, 8 months ago (2014-04-23 16:16:44 UTC) #2
rsadam
https://codereview.chromium.org/249493002/diff/1/ui/keyboard/resources/main.css File ui/keyboard/resources/main.css (right): https://codereview.chromium.org/249493002/diff/1/ui/keyboard/resources/main.css#newcode35 ui/keyboard/resources/main.css:35: -webkit-linear-gradient(rgba(0, 0, 255,0.5), rgba(0, 0, 255, 0.5)); On 2014/04/23 ...
6 years, 8 months ago (2014-04-23 16:37:25 UTC) #3
bshe
On 2014/04/23 16:37:25, rsadam wrote: > https://codereview.chromium.org/249493002/diff/1/ui/keyboard/resources/main.css > File ui/keyboard/resources/main.css (right): > > https://codereview.chromium.org/249493002/diff/1/ui/keyboard/resources/main.css#newcode35 > ...
6 years, 8 months ago (2014-04-23 16:40:57 UTC) #4
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-04-23 16:42:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/249493002/20001
6 years, 8 months ago (2014-04-23 16:42:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 17:31:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-23 17:31:25 UTC) #8
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-04-23 17:50:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/249493002/20001
6 years, 8 months ago (2014-04-23 17:51:06 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 00:07:45 UTC) #11
Message was sent while issue was closed.
Change committed as 265782

Powered by Google App Engine
This is Rietveld 408576698