Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2494883003: Add metadata to json results before uploading (Closed)

Created:
4 years, 1 month ago by nednguyen
Modified:
4 years, 1 month ago
Reviewers:
estaab
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M scripts/slave/recipe_modules/test_results/resources/upload_test_results.py View 2 chunks +36 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py View 1 chunk +16 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
4 years, 1 month ago (2016-11-11 00:51:28 UTC) #2
nednguyen
https://codereview.chromium.org/2494883003/diff/1/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py File scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py (left): https://codereview.chromium.org/2494883003/diff/1/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py#oldcode155 scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py:155: files = [(os.path.basename(input_json_file_path), input_json_file_path)] I notice that this wasn't ...
4 years, 1 month ago (2016-11-11 00:53:15 UTC) #3
estaab
lgtm Looks great, thanks for the quick turnaround! https://codereview.chromium.org/2494883003/diff/1/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py File scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py (left): https://codereview.chromium.org/2494883003/diff/1/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py#oldcode155 scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py:155: files ...
4 years, 1 month ago (2016-11-11 04:57:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494883003/1
4 years, 1 month ago (2016-11-11 11:34:34 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 11:44:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/86356c164014cf93140c...

Powered by Google App Engine
This is Rietveld 408576698