[Sync] Allow sync start without sign-in if the local sync backend is on.

chrome/browser/sync/profile_sync_service_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
+#include "base/path_service.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/invalidation/profile_invalidation_provider_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
 #include "chrome/browser/signin/about_signin_internals_factory.h"
 #include "chrome/browser/signin/chrome_signin_client_factory.h"
 #include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/chrome_sync_client.h"
 #include "chrome/browser/sync/supervised_user_signin_manager_wrapper.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/web_data_service_factory.h"
 #include "chrome/common/channel_info.h"
+#include "components/browser_sync/browser_sync_switches.h"
 #include "components/browser_sync/profile_sync_components_factory_impl.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/network_time/network_time_tracker.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/sync/driver/signin_manager_wrapper.h"
 #include "components/sync/driver/startup_controller.h"
 #include "components/sync/driver/sync_util.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 23 matching lines @@
 
 void UpdateNetworkTime(const base::Time& network_time,
                        const base::TimeDelta& resolution,
                        const base::TimeDelta& latency) {
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(&UpdateNetworkTimeOnUIThread, network_time, resolution,
                  latency, base::TimeTicks::Now()));
 }
 
+#if defined(OS_WIN)
+static const base::FilePath::CharType kLoopbackServerBackendFilename[] =
+    FILE_PATH_LITERAL("profile.pb");
+#endif
+
 }  // anonymous namespace
 
 // static
 ProfileSyncServiceFactory* ProfileSyncServiceFactory::GetInstance() {
   return base::Singleton<ProfileSyncServiceFactory>::get();
 }
 
 // static
 ProfileSyncService* ProfileSyncServiceFactory::GetForProfile(
     Profile* profile) {
@@ skipping 50 matching lines @@
 
 ProfileSyncServiceFactory::~ProfileSyncServiceFactory() {
 }
 
 KeyedService* ProfileSyncServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   ProfileSyncService::InitParams init_params;
 
   Profile* profile = Profile::FromBrowserContext(context);
 
-  SigninManagerBase* signin = SigninManagerFactory::GetForProfile(profile);
+  init_params.network_time_update_callback = base::Bind(&UpdateNetworkTime);
+  init_params.base_directory = profile->GetPath();
+  init_params.url_request_context = profile->GetRequestContext();
+  init_params.debug_identifier = profile->GetDebugName();
+  init_params.channel = chrome::GetChannel();
+  init_params.blocking_pool = content::BrowserThread::GetBlockingPool();
+  init_params.local_sync_backend_enabled = false;
 
-  // Always create the GCMProfileService instance such that we can listen to
-  // the profile notifications and purge the GCM store when the profile is
-  // being signed out.
-  gcm::GCMProfileServiceFactory::GetForProfile(profile);
+#if defined(OS_WIN)
+  init_params.local_sync_backend_enabled =
+      base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableLocalSyncBackend);
 
-  // TODO(atwilson): Change AboutSigninInternalsFactory to load on startup
-  // once http://crbug.com/171406 has been fixed.
-  AboutSigninInternalsFactory::GetForProfile(profile);
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(

[Nicolas Zea, 2016/11/19 00:36:42]

should all of this logic be dependent on local_sync_backend_enabled? Perhaps put
within a conditional?

[pastarmovj, 2016/11/22 12:38:08]

Done.

+          switches::kLocalSyncBackendDir)) {
+    init_params.local_sync_backend_folder =
+        base::CommandLine::ForCurrentProcess()->GetSwitchValuePath(
+            switches::kLocalSyncBackendDir);
+  } else {
+    // TODO(pastarmovj): Add DIR_ROAMING_USER_DATA to PathService to simplify
+    // this code and move the logic in its right place. See crbug/657810.
+    CHECK(base::PathService::Get(base::DIR_APP_DATA,
+                                 &init_params.local_sync_backend_folder));
+    init_params.local_sync_backend_folder =
+        init_params.local_sync_backend_folder.Append(
+            FILE_PATH_LITERAL("Chrome/User Data"));
+  }
+  // This code as it is now will assume the same profile order is present on all
+  // machines, which is not a given. It is to be defined if only the Default
+  // profile should get this treatment or all profile as is the case now. The
+  // solution for now will be to assume profiles are created in the same order
+  // on all machines and in the future decide if only the Default one should be
+  // considered roamed.
+  init_params.local_sync_backend_folder =
+      init_params.local_sync_backend_folder.Append(
+          init_params.base_directory.BaseName());
+  init_params.local_sync_backend_folder =
+      init_params.local_sync_backend_folder.Append(
+          kLoopbackServerBackendFilename);
+#endif  // defined(OS_WIN)
 
-  init_params.signin_wrapper =
-      base::MakeUnique<SupervisedUserSigninManagerWrapper>(profile, signin);
-  init_params.oauth2_token_service =
-      ProfileOAuth2TokenServiceFactory::GetForProfile(profile);
-  init_params.gaia_cookie_manager_service =
-      GaiaCookieManagerServiceFactory::GetForProfile(profile);
+  if (!init_params.local_sync_backend_enabled) {
+    SigninManagerBase* signin = SigninManagerFactory::GetForProfile(profile);
 
-  // TODO(tim): Currently, AUTO/MANUAL settings refer to the *first* time sync
-  // is set up and *not* a browser restart for a manual-start platform (where
-  // sync has already been set up, and should be able to start without user
-  // intervention). We can get rid of the browser_default eventually, but
-  // need to take care that ProfileSyncService doesn't get tripped up between
-  // those two cases. Bug 88109.
-  init_params.start_behavior = browser_defaults::kSyncAutoStarts
-                                   ? ProfileSyncService::AUTO_START
-                                   : ProfileSyncService::MANUAL_START;
+    // Always create the GCMProfileService instance such that we can listen to
+    // the profile notifications and purge the GCM store when the profile is
+    // being signed out.
+    gcm::GCMProfileServiceFactory::GetForProfile(profile);
+
+    // TODO(atwilson): Change AboutSigninInternalsFactory to load on startup
+    // once http://crbug.com/171406 has been fixed.
+    AboutSigninInternalsFactory::GetForProfile(profile);
+
+    init_params.signin_wrapper =
+        base::MakeUnique<SupervisedUserSigninManagerWrapper>(profile, signin);
+    init_params.oauth2_token_service =
+        ProfileOAuth2TokenServiceFactory::GetForProfile(profile);
+    init_params.gaia_cookie_manager_service =
+        GaiaCookieManagerServiceFactory::GetForProfile(profile);
+
+    // TODO(tim): Currently, AUTO/MANUAL settings refer to the *first* time sync
+    // is set up and *not* a browser restart for a manual-start platform (where
+    // sync has already been set up, and should be able to start without user
+    // intervention). We can get rid of the browser_default eventually, but
+    // need to take care that ProfileSyncService doesn't get tripped up between
+    // those two cases. Bug 88109.
+    init_params.start_behavior = browser_defaults::kSyncAutoStarts
+                                     ? ProfileSyncService::AUTO_START
+                                     : ProfileSyncService::MANUAL_START;
+  } else {
+    // In local mode none of the sign-in stuff is required.
+    init_params.start_behavior = ProfileSyncService::AUTO_START;

[Nicolas Zea, 2016/11/19 00:36:42]

I think it's cleaner to move this up to the #if defined(OS_WIN) section

[pastarmovj, 2016/11/22 12:38:08]

Done.

Btw technically all of the above can always be initialized (up to setting the
right start_behavior). The whole reason I put this in a condition here is to
more easily catch errors where the network is used when in local mode. If you'd
rather wish that we don't do this here I can remove this condition altogether.

+  }
 
   if (!client_factory_) {
     init_params.sync_client =
         base::MakeUnique<browser_sync::ChromeSyncClient>(profile);
   } else {
     init_params.sync_client = client_factory_->Run(profile);
   }
 
-  init_params.network_time_update_callback = base::Bind(&UpdateNetworkTime);
-  init_params.base_directory = profile->GetPath();
-  init_params.url_request_context = profile->GetRequestContext();
-  init_params.debug_identifier = profile->GetDebugName();
-  init_params.channel = chrome::GetChannel();
-  init_params.blocking_pool = content::BrowserThread::GetBlockingPool();
-
   auto pss = base::MakeUnique<ProfileSyncService>(std::move(init_params));
 
   // Will also initialize the sync client.
   pss->Initialize();
   return pss.release();
 }
 
 // static
 bool ProfileSyncServiceFactory::HasProfileSyncService(Profile* profile) {
   return GetInstance()->GetServiceForBrowserContext(profile, false) != nullptr;
 }
 
 // static
 void ProfileSyncServiceFactory::SetSyncClientFactoryForTest(
     SyncClientFactory* client_factory) {
   client_factory_ = client_factory;
 }
 
 // static
 ProfileSyncServiceFactory::SyncClientFactory*
     ProfileSyncServiceFactory::client_factory_ = nullptr;