chrome/browser/ui/sync/sync_promo_ui.cc - Issue 2494873003: [Sync] Allow sync start without sign-in if the local sync backend is on.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/sync/sync_promo_ui.cc

Issue 2494873003: [Sync] Allow sync start without sign-in if the local sync backend is on. (Closed)

Patch Set: Merge pref changes from https://codereview.chromium.org/2528163002/. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/sync/profile_sync_service_factory.cc ('K') | « chrome/browser/sync/profile_sync_service_factory.cc ('k') | components/browser_sync/profile_sync_service.h » ('j') | components/browser_sync/profile_sync_service_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/sync/sync_promo_ui.h"	5 #include "chrome/browser/ui/sync/sync_promo_ui.h"

6	6

7 #include "chrome/browser/profiles/profile.h"	7 #include "chrome/browser/profiles/profile.h"

8 #include "chrome/browser/signin/signin_promo_util.h"	8 #include "chrome/browser/signin/signin_promo_util.h"

9	9

10 bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {	10 bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {

11 // Don't show sync promo if the sign in promo should not be shown.	11 // Don't show sync promo if the sign in promo should not be shown.

12 if (!signin::ShouldShowPromo(profile)) {	12 if (!signin::ShouldShowPromo(profile)) {

13 return false;	13 return false;

14 }	14 }

15	15

16 // Don't show if sync is not allowed to start.	16 // Don't show if sync is not allowed to start or is running in local mode.

17 if (!profile->IsSyncAllowed())	17 if (!profile->IsSyncAllowed() \|\| profile->IsLocalSyncEnabled())
	Nicolas Zea 2016/12/15 00:37:28 See other comment. Is this the only callsite that See other comment. Is this the only callsite that uses Profile::IsLocalSyncEnabled? Seems unnecessary to expose that at the profile level. I wonder if this place should just be checking the pref directly then via SyncPrefs (same goes for IsSyncAllowed) pastarmovj 2016/12/16 17:04:48 Yes this is the only site that needs IsLocalSyncEn Show quoted text On 2016/12/15 00:37:28, Nicolas Zea wrote: > See other comment. Is this the only callsite that uses > Profile::IsLocalSyncEnabled? Seems unnecessary to expose that at the profile > level. I wonder if this place should just be checking the pref directly then via > SyncPrefs (same goes for IsSyncAllowed) Yes this is the only site that needs IsLocalSyncEnabled but there are many that use IsSyncAllowed. I removed my function in favor of direct access to the pref.
18 return false;	18 return false;

19	19

20 return true;	20 return true;

21 }	21 }

OLD	NEW