Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issue 2494873002: Mojo C++ bindings: switch mime_handler mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch mime_handler mojom target to use STL types. BUG=624136 Committed: https://crrev.com/ad8a4ece43e32abb8bccacd89e382ae17afad8c2 Cr-Commit-Position: refs/heads/master@{#431445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M extensions/browser/api/mime_handler_private/mime_handler_private.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Reilly. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-10 23:22:15 UTC) #4
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-10 23:33:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494873002/1
4 years, 1 month ago (2016-11-11 00:50:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 01:33:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 01:38:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad8a4ece43e32abb8bccacd89e382ae17afad8c2
Cr-Commit-Position: refs/heads/master@{#431445}

Powered by Google App Engine
This is Rietveld 408576698