Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2494853002: Make gn_run_binary.py do the right thing for compiled_action (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make gn_run_binary.py do the right thing for compiled_action R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b5b563c52b7c9d9bf8207af5784f3aab6980f577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M build/compiled_action.gni View 5 chunks +12 lines, -4 lines 0 comments Download
M build/gn_run_binary.py View 2 chunks +20 lines, -6 lines 0 comments Download
M build/prebuilt_dart_sdk.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-11-10 22:04:52 UTC) #2
Cutch
lgtm LGTM
4 years, 1 month ago (2016-11-10 22:38:35 UTC) #3
zra
4 years, 1 month ago (2016-11-11 16:29:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5b563c52b7c9d9bf8207af5784f3aab6980f577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698