components/policy/core/common/cloud/cloud_policy_validator_unittest.cc - Issue 2494843002: Don't pass domain and verification key to validation when not required

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

Issue 2494843002: Don't pass domain and verification key to validation when not required (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_validator.cc ('k') | components/policy/core/common/cloud/user_cloud_policy_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc b/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

index e0a7f980d3c6f9792e7ad7e3cc14bacc308761fc..23f4f5dd9b132882a35e85f4efb8383b0362e7a1 100644

--- a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

+++ b/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

@@ -107,12 +107,13 @@ class CloudPolicyValidatorTest : public testing::Test {

cached_key_signature_,

GetPolicyVerificationKey(),

owning_domain_);

- validator->ValidateSignature(public_key,

- GetPolicyVerificationKey(),

- owning_domain_,

- allow_key_rotation_);

- if (allow_key_rotation_)

+ if (allow_key_rotation_) {

+ validator->ValidateSignatureAllowingRotation(

+ public_key, GetPolicyVerificationKey(), owning_domain_);

validator->ValidateInitialKey(GetPolicyVerificationKey(), owning_domain_);

+ } else {

+ validator->ValidateSignature(public_key);

+ }

return base::WrapUnique(validator);

}