chrome/browser/chromeos/policy/device_local_account_policy_store.cc - Issue 2494843002: Don't pass domain and verification key to validation when not required

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

Issue 2494843002: Don't pass domain and verification key to validation when not required (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_policy_store.cc b/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

index ab474719445c5a6235b07478cd85d2e39446f6c0..3cd5673c1b3d3548f17ccba78615f3d2b1282767 100644

--- a/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

@@ -9,8 +9,6 @@

#include "base/bind.h"

#include "base/callback.h"

#include "base/memory/ptr_util.h"

-#include "chrome/browser/browser_process.h"

-#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"

#include "chromeos/dbus/session_manager_client.h"

#include "components/ownership/owner_key_util.h"

#include "components/policy/core/common/cloud/device_management_service.h"

@@ -175,12 +173,7 @@ void DeviceLocalAccountPolicyStore::Validate(

CloudPolicyValidatorBase::DEVICE_ID_REQUIRED);

validator->ValidatePayload();

- policy::BrowserPolicyConnectorChromeOS* connector =

- g_browser_process->platform_part()->browser_policy_connector_chromeos();

- validator->ValidateSignature(key->as_string(),

- GetPolicyVerificationKey(),

- connector->GetEnterpriseDomain(),

- false);

+ validator->ValidateSignature(key->as_string());

validator.release()->StartValidation(callback);

}