chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc - Issue 2494843002: Don't pass domain and verification key to validation when not required

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

Issue 2494843002: Don't pass domain and verification key to validation when not required (Closed)

Patch Set: Address feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_local_account_policy_store.cc » ('j') | chrome/browser/chromeos/policy/device_local_account_policy_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

index b3bfde5f21bf78f3fa2c780e86239b174fc0ab6d..3993ab416042aa05cda3a90b584d0a84102bfde1 100644

--- a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

+++ b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

@@ -55,10 +55,9 @@ void DeviceCloudPolicyStoreChromeOS::Store(

std::unique_ptr<DeviceCloudPolicyValidator> validator(

CreateValidator(policy));

- validator->ValidateSignature(public_key->as_string(),

- GetPolicyVerificationKey(),

- install_attributes_->GetDomain(),

- true);

+ validator->ValidateSignatureAllowingRotation(

+ public_key->as_string(), GetPolicyVerificationKey(),

+ install_attributes_->GetDomain());

validator->ValidateAgainstCurrentPolicy(

device_settings_service_->policy_data(),

CloudPolicyValidatorBase::TIMESTAMP_FULLY_VALIDATED,