Correct mappings for Xbox One S gamepad with new firmware

Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG=664716
TEST=http://html5gamepad.com/

Committed: https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a
Cr-Commit-Position: refs/heads/master@{#432119}

[cgutman, 2016-11-12 06:58:30]

Description was changed from

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.

Any Xbox One S gamepad running this new firmware will have a new
product ID when connected via Bluetooth.

For Mac and Linux, handling this is easy because we can just look at
the PID and use a different mapping.

Since we don't have easy VID/PID access on Android (until 4.4), we must
be more clever. The new firmware moves the trigger axes from Z/RZ to
BRAKE/GAS, so we can assume that if BRAKE or GAS is present, we are
running the newer firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

to

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.

Any Xbox One S gamepad running this new firmware will have a new
product ID when connected via Bluetooth.

For Mac and Linux, handling this is easy because we can just look at
the PID and use a different mapping.

Since we don't have easy VID/PID access on Android (until 4.4), we must
be more clever. The new firmware moves the trigger axes from Z/RZ to
BRAKE/GAS, so we can assume that if BRAKE or GAS is present, we are
running the newer firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

[cgutman, 2016-11-12 06:58:31]

aicommander@gmail.com changed reviewers:
+ aelias@chromium.org, bajones@chromium.org

[cgutman, 2016-11-12 06:59:38]

Yet another surprise by Microsoft ;)

[bajones, 2016-11-12 07:31:15]

On 2016/11/12 06:59:38, cgutman wrote:
> Yet another surprise by Microsoft ;)

Sounds like this was fun to sort out. :P

I guess the question I have is: How much do we care about the old firmware? The
S controllers haven't been out long, I assume they'll start shipping with the
new FW soon, and the update is free to anyone. Seems like detecting the
difference between the two is a very short term problem. As such I'd be in favor
of either dropping the mappings for the old FW entirely (which should be
especially nice for the Android case) or at the very least sticking some
comments in there indicating that we should come back in, say, 6 months and drop
the old mapping so that we don't endlessly accumulate mapping cruft over time.

Curious what aelias@ thinks on the subject.

[cgutman, 2016-11-12 07:44:41]

On 2016/11/12 07:31:15, bajones wrote:
> I guess the question I have is: How much do we care about the old firmware?
The
> S controllers haven't been out long, I assume they'll start shipping with the
> new FW soon, and the update is free to anyone. Seems like detecting the
> difference between the two is a very short term problem. As such I'd be in
favor
> of either dropping the mappings for the old FW entirely (which should be
> especially nice for the Android case) or at the very least sticking some
> comments in there indicating that we should come back in, say, 6 months and
drop
> the old mapping so that we don't endlessly accumulate mapping cruft over time.

I think for the time being we'll want to handle both. The controllers can only
be
updated by the Xbox One itself or connecting them via USB or the Xbox Wireless
Adapter to a Windows 10 machine and manually running the Xbox Accessories app.
They aren't updatable over Bluetooth.

Users running Windows 7/8, macOS, or Linux won't be able to update the firmware.
Even with Windows 10, the OS doesn't prompt you to do the upgrade. You have to
look for it via the Xbox Accessories app. Xbox One S owners though should get
it automatically or be prompted for it.

I'm definitely not opposed to a comment on those old mappings if we don't want
to carry them forever.

[aelias_OOO_until_Jul13, 2016-11-13 01:17:54]

I'd support just deleting the old mapping and relying on the unknown mapping. 
We could also update Windows/Mac unknown mapping to behave more like Android if
that helps.

[cgutman, 2016-11-13 05:50:02]

On 2016/11/13 01:17:54, aelias wrote:
> I'd support just deleting the old mapping and relying on the unknown mapping. 
> We could also update Windows/Mac unknown mapping to behave more like Android
if
> that helps.

For Mac and Linux, that would mean we would be breaking compatibility with
mappings made for unknown gamepads on previous versions of Chrome. I think
the change would probably be a net gain, since the current Mac and Linux
default mappings don't follow any of the HID conventions that could allow
us to do smarter things with unknown gamepads.

For Android, should we just remove the mapping and let it fall through to
the unknown mapping (claiming the mapping is not standard) or call the
mapping standard but run the risk that it gets used on the older FW
(and we break spec by claiming a standard mapping but really being
all screwed up)?

[aelias_OOO_until_Jul13, 2016-11-14 19:42:40]

On 2016/11/13 at 05:50:02, aicommander wrote:
> On 2016/11/13 01:17:54, aelias wrote:
> > I'd support just deleting the old mapping and relying on the unknown
mapping. 
> > We could also update Windows/Mac unknown mapping to behave more like Android
if
> > that helps.
> 
> For Mac and Linux, that would mean we would be breaking compatibility with
> mappings made for unknown gamepads on previous versions of Chrome. I think
> the change would probably be a net gain, since the current Mac and Linux
> default mappings don't follow any of the HID conventions that could allow
> us to do smarter things with unknown gamepads.

Well, I suggest starting by just deleting the Xbox One S mapping in this patch.
If you want to upload a separate patch uniformizing the mappings, I'd support
trying that (but let's just keep it separate in case we get complaints about
that change and want to revert without re-breaking the Xbox One S).

> 
> For Android, should we just remove the mapping and let it fall through to
> the unknown mapping (claiming the mapping is not standard) or call the
> mapping standard but run the risk that it gets used on the older FW
> (and we break spec by claiming a standard mapping but really being
> all screwed up)?

Let's fall through to unknown mapping in the normal way, not making claims that
it's standard.  That's how we treat most gamepads.

[cgutman, 2016-11-15 04:09:06]

Description was changed from

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.

Any Xbox One S gamepad running this new firmware will have a new
product ID when connected via Bluetooth.

For Mac and Linux, handling this is easy because we can just look at
the PID and use a different mapping.

Since we don't have easy VID/PID access on Android (until 4.4), we must
be more clever. The new firmware moves the trigger axes from Z/RZ to
BRAKE/GAS, so we can assume that if BRAKE or GAS is present, we are
running the newer firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

to

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

[cgutman, 2016-11-15 04:14:23]

I've removed the Android mapping completely, so we'll use the unknown mapping.

For Mac and Linux, I've replaced the old mapping with a mapping for the new
firmware. Later, if we get a better default mapping on these platforms, we
can nuke these then.

[aelias_OOO_until_Jul13, 2016-11-15 04:29:26]

java changes lgtm

[bajones, 2016-11-15 04:31:25]

On 2016/11/15 04:14:23, cgutman wrote:
> I've removed the Android mapping completely, so we'll use the unknown mapping.
> 
> For Mac and Linux, I've replaced the old mapping with a mapping for the new
> firmware. Later, if we get a better default mapping on these platforms, we
> can nuke these then.

Thanks, LGTM.

[cgutman, 2016-11-15 04:32:06]

The CQ bit was checked by aicommander@gmail.com

[commit-bot: I haz the power, 2016-11-15 04:32:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 05:44:17]

Description was changed from

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

to

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

[commit-bot: I haz the power, 2016-11-15 05:44:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 05:48:45]

Description was changed from

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG=664716
TEST=http://html5gamepad.com/
==========

to

==========
Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG=664716
TEST=http://html5gamepad.com/

Committed: https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a
Cr-Commit-Position: refs/heads/master@{#432119}
==========

[commit-bot: I haz the power, 2016-11-15 05:48:46]

Patchset 2 (id:??) landed as
https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a
Cr-Commit-Position: refs/heads/master@{#432119}