third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp - Issue 2494823002: V8ScriptValueSerializer: Use PartitionAlloc for the buffer, and avoid copying it into a String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp

Issue 2494823002: V8ScriptValueSerializer: Use PartitionAlloc for the buffer, and avoid copying it into a String. (Closed)

Patch Set: initialize SerializedScriptValue::m_dataBufferSize Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/wtf/allocator/Partitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp b/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp

index 348e9e882fc5cc47d63e03969a7662893a0136c1..a1ffde32c094d34ee6f2fda4185d9a19142cf827 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp

@@ -49,20 +49,17 @@ v8::Local<v8::Value> SerializedScriptValueForModulesFactory::deserialize(

// in |this| being destroyed. Holding a RefPtr ensures we are alive (along

// with our internal data) throughout the operation.

RefPtr<SerializedScriptValue> protect(value);

- String& data = value->data();

- if (!data.impl())

+ if (!value->dataLengthInBytes())

return v8::Null(isolate);

static_assert(sizeof(SerializedScriptValueWriter::BufferValueType) == 2,

"BufferValueType should be 2 bytes");

- data.ensure16Bit();

// FIXME: SerializedScriptValue shouldn't use String for its underlying

// storage. Instead, it should use SharedBuffer or Vector<uint8_t>. The

// information stored in m_data isn't even encoded in UTF-16. Instead,

// unicode characters are encoded as UTF-8 with two code units per UChar.

SerializedScriptValueReaderForModules reader(

- reinterpret_cast<const uint8_t*>(data.impl()->characters16()),

- 2 * data.length(), blobInfo, value->blobDataHandles(),

- ScriptState::current(isolate));

+ value->data(), value->dataLengthInBytes(), blobInfo,

+ value->blobDataHandles(), ScriptState::current(isolate));

ScriptValueDeserializerForModules deserializer(

reader, messagePorts, value->getArrayBufferContentsArray(),

value->getImageBitmapContentsArray());