third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp - Issue 2494823002: V8ScriptValueSerializer: Use PartitionAlloc for the buffer, and avoid copying it into a String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

Issue 2494823002: V8ScriptValueSerializer: Use PartitionAlloc for the buffer, and avoid copying it into a String. (Closed)

Patch Set: initialize SerializedScriptValue::m_dataBufferSize Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

index 62c40201544db510fa70ea2d94d29978c9e683f7..5a6c7939fa87419923c7843add4dadc9f78286c1 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

@@ -29,10 +29,8 @@ V8ScriptValueDeserializer::V8ScriptValueDeserializer(

: m_scriptState(std::move(scriptState)),

m_serializedScriptValue(std::move(serializedScriptValue)),

m_deserializer(m_scriptState->isolate(),

- reinterpret_cast<const uint8_t*>(

- m_serializedScriptValue->data().ensure16Bit(),

- m_serializedScriptValue->data().characters16()),

- m_serializedScriptValue->data().length() * 2,

+ m_serializedScriptValue->data(),

+ m_serializedScriptValue->dataLengthInBytes(),

this) {

DCHECK(RuntimeEnabledFeatures::v8BasedStructuredCloneEnabled());

m_deserializer.SetSupportsLegacyWireFormat(true);