V8ScriptValueSerializer: Use PartitionAlloc for the buffer, and avoid copying it into a String.

third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/serialization/V8ScriptValueSerializer.h"
 
 #include "bindings/core/v8/ToV8.h"
 #include "bindings/core/v8/V8Blob.h"
 #include "bindings/core/v8/V8CompositorProxy.h"
 #include "bindings/core/v8/V8File.h"
 #include "bindings/core/v8/V8FileList.h"
 #include "bindings/core/v8/V8ImageBitmap.h"
 #include "bindings/core/v8/V8ImageData.h"
 #include "bindings/core/v8/V8MessagePort.h"
 #include "bindings/core/v8/V8OffscreenCanvas.h"
 #include "core/dom/DOMArrayBufferBase.h"
 #include "core/html/ImageData.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "public/platform/WebBlobInfo.h"
 #include "wtf/AutoReset.h"
 #include "wtf/DateMath.h"
+#include "wtf/allocator/Partitions.h"
 #include "wtf/text/StringUTF8Adaptor.h"
 
 namespace blink {
 
 V8ScriptValueSerializer::V8ScriptValueSerializer(
     RefPtr<ScriptState> scriptState)
     : m_scriptState(std::move(scriptState)),
       m_serializedScriptValue(SerializedScriptValue::create()),
       m_serializer(m_scriptState->isolate(), this) {
   DCHECK(RuntimeEnabledFeatures::v8BasedStructuredCloneEnabled());
@@ skipping 24 matching lines @@
     return nullptr;
   }
   DCHECK(wroteValue);
 
   // Finalize the transfer (e.g. neutering array buffers).
   finalizeTransfer(exceptionState);
   if (exceptionState.hadException())
     return nullptr;
 
   // Finalize the results.
-  std::vector<uint8_t> buffer = m_serializer.ReleaseBuffer();
-  // Currently, the output must be padded to a multiple of two bytes.
-  // TODO(jbroman): Remove this old conversion to WTF::String.
-  if (buffer.size() % 2)
-    buffer.push_back(0);
+  std::pair<uint8_t*, size_t> buffer = m_serializer.Release();
   m_serializedScriptValue->setData(
-      String(reinterpret_cast<const UChar*>(&buffer[0]), buffer.size() / 2));
+      SerializedScriptValue::DataBufferPtr(buffer.first), buffer.second);
   return std::move(m_serializedScriptValue);
 }
 
 void V8ScriptValueSerializer::prepareTransfer(Transferables* transferables) {
   if (!transferables)
     return;
   m_transferables = transferables;
 
   // Transfer array buffers.
   for (uint32_t i = 0; i < transferables->arrayBuffers.size(); i++) {
@@ skipping 282 matching lines @@
     return v8::Just(true);
   }
   if (!exceptionState.hadException()) {
     StringView interface = wrappable->wrapperTypeInfo()->interfaceName;
     exceptionState.throwDOMException(
         DataCloneError, interface + " object could not be cloned.");
   }
   return v8::Nothing<bool>();
 }
 
+void* V8ScriptValueSerializer::ReallocateBufferMemory(void* oldBuffer,
+                                                      size_t size,
+                                                      size_t* actualSize) {
+  *actualSize = WTF::Partitions::bufferActualSize(size);
+  return WTF::Partitions::bufferRealloc(oldBuffer, size,
+                                        "SerializedScriptValue buffer");
+}
+
+void V8ScriptValueSerializer::FreeBufferMemory(void* buffer) {
+  return WTF::Partitions::bufferFree(buffer);
+}
+
 }  // namespace blink