Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2494813002: MD Settings: slight tweaks to when the metrics reporting restart button shows up (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: slight tweaks to when the metrics reporting restart button shows up Should also hopefully fix the tests on official builders. R=dpapad@chromium.org BUG=664192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2c353bc35ec243f7a62600f92a184c58dba6df75 Cr-Commit-Position: refs/heads/master@{#431486}

Patch Set 1 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/metrics_reporting_tests.js View 3 chunks +46 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Dan Beam
4 years, 1 month ago (2016-11-10 21:35:21 UTC) #4
dpapad
lgtm
4 years, 1 month ago (2016-11-11 03:29:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494813002/40001
4 years, 1 month ago (2016-11-11 03:34:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-11-11 03:45:33 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 03:56:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c353bc35ec243f7a62600f92a184c58dba6df75
Cr-Commit-Position: refs/heads/master@{#431486}

Powered by Google App Engine
This is Rietveld 408576698