[sensors] Improve the generic sensors current layout tests.

[sensors] Improve the generic sensors current layout tests.

Move all the tests that are going to be common in a single file.
Each of the sensor type will call a function to get the generic
tests to run. Specific sensor test can still be added in their
respective html files.

BUG=606766
Committed: https://crrev.com/d6305cf853f1e9e6fb1cd9afbf3f9483204e33be
Cr-Commit-Position: refs/heads/master@{#431960}

[darktears, 2016-11-11 23:57:21]

alexis.menard@intel.com changed reviewers:
+ alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com,
timvolodine@chromium.org

[darktears, 2016-11-11 23:57:33]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 23:57:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 02:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 02:34:30]

Dry run: This issue passed the CQ dry run.

[Mikhail, 2016-11-12 18:38:24]

lgtm, thanks!

[shalamov, 2016-11-14 09:14:56]

lgtm

[darktears, 2016-11-14 16:46:38]

alexis.menard@intel.com changed reviewers:
+ reillyg@chromium.org

[darktears, 2016-11-14 16:47:40]

The CQ bit was checked by alexis.menard@intel.com

[commit-bot: I haz the power, 2016-11-14 16:48:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-11-14 18:36:12]

lgtm with nits

https://codereview.chromium.org/2494773004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
(right):

https://codereview.chromium.org/2494773004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:62: let
configuration = mockSensor.active_sensor_configurations_[0];
nit: Indentation issue.

https://codereview.chromium.org/2494773004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:196:
.then((mockSensor) => {
nit: Parenthesis not necessary around mockSensor here and below.

https://codereview.chromium.org/2494773004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:207:
testRunner.setPageVisibility("hidden");
nit: 'hidden'

https://codereview.chromium.org/2494773004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js:211:
testRunner.setPageVisibility("visible");
nit: 'visible'

[darktears, 2016-11-14 18:53:24]

The CQ bit was unchecked by alexis.menard@intel.com

[darktears, 2016-11-14 18:57:14]

The CQ bit was checked by alexis.menard@intel.com

[darktears, 2016-11-14 18:57:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com
Link to the patchset: https://codereview.chromium.org/2494773004/#ps20001
(title: "Fix Reilly comments")

[commit-bot: I haz the power, 2016-11-14 18:58:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:21:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-14 23:33:34]

Description was changed from

==========
[sensors] Improve the generic sensors current layout tests.

Move all the tests that are going to be common in a single file.
Each of the sensor type will call a function to get the generic
tests to run. Specific sensor test can still be added in their
respective html files.

BUG=606766
==========

to

==========
[sensors] Improve the generic sensors current layout tests.

Move all the tests that are going to be common in a single file.
Each of the sensor type will call a function to get the generic
tests to run. Specific sensor test can still be added in their
respective html files.

BUG=606766

Committed: https://crrev.com/d6305cf853f1e9e6fb1cd9afbf3f9483204e33be
Cr-Commit-Position: refs/heads/master@{#431960}
==========

[commit-bot: I haz the power, 2016-11-14 23:33:35]

Patchset 2 (id:??) landed as
https://crrev.com/d6305cf853f1e9e6fb1cd9afbf3f9483204e33be
Cr-Commit-Position: refs/heads/master@{#431960}