Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 2494753003: [turbofan] Introduce an ExternalPointer type. (Closed)
Patch Set: Stronger ducktape. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/escape-analysis-unittest.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index 0b9935081bd99f87b2530130d572fc297453aa35..ba1b719ff57cc77020118193e2b8130c5a4c251b 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -70,11 +70,6 @@ class JSTypedLoweringTest : public TypedGraphTest {
return buffer;
}
- Matcher<Node*> IsIntPtrConstant(intptr_t value) {
- return sizeof(value) == 4 ? IsInt32Constant(static_cast<int32_t>(value))
- : IsInt64Constant(static_cast<int64_t>(value));
- }
-
JSOperatorBuilder* javascript() { return &javascript_; }
private:
@@ -569,7 +564,7 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArray) {
EXPECT_THAT(
r.replacement(),
IsLoadBuffer(BufferAccess(type),
- IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
+ IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
offset_matcher,
IsNumberConstant(array->byte_length()->Number()), effect,
control));
@@ -605,7 +600,7 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArrayWithSafeKey) {
EXPECT_THAT(
r.replacement(),
IsLoadElement(access,
- IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
+ IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
key, effect, control));
}
}
@@ -650,11 +645,11 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
r.replacement(),
- IsStoreBuffer(BufferAccess(type),
- IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
- offset_matcher,
- IsNumberConstant(array->byte_length()->Number()), value,
- effect, control));
+ IsStoreBuffer(
+ BufferAccess(type),
+ IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
+ offset_matcher, IsNumberConstant(array->byte_length()->Number()),
+ value, effect, control));
}
}
}
@@ -703,11 +698,11 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
r.replacement(),
- IsStoreBuffer(BufferAccess(type),
- IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
- offset_matcher,
- IsNumberConstant(array->byte_length()->Number()),
- value_matcher, effect_matcher, control_matcher));
+ IsStoreBuffer(
+ BufferAccess(type),
+ IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
+ offset_matcher, IsNumberConstant(array->byte_length()->Number()),
+ value_matcher, effect_matcher, control_matcher));
}
}
}
@@ -744,7 +739,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {
EXPECT_THAT(
r.replacement(),
IsStoreElement(
- access, IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
+ access, IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
key, value, effect, control));
}
}
« no previous file with comments | « test/unittests/compiler/escape-analysis-unittest.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698