Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2494753003: [turbofan] Introduce an ExternalPointer type. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce an ExternalPointer type. This adds a new ExternalPointer type, which is an Internal type that is used for ExternalReferences and other pointer values, like the pointers into the asm.js heap. It also adds a PointerConstant operator, which we use to represents these raw constants (we can probably remove that particular operator again once WebAssembly ships with the validator). R=mvstanton@chromium.org BUG=v8:5267, v8:5270 Committed: https://crrev.com/7d24f1aefa89a8fe691d7820e39e424eef407df4 Cr-Commit-Position: refs/heads/master@{#40923}

Patch Set 1 #

Patch Set 2 : Also fix CodeGenerator for 32-bit. #

Patch Set 3 : Stronger ducktape. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -109 lines) Patch
M src/compiler/access-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M src/compiler/common-node-cache.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +35 lines, -30 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/types.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +13 lines, -18 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +1 line, -6 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 6 chunks +13 lines, -18 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-11 10:41:47 UTC) #1
mvstanton
Nice cleanup! LGTM
4 years, 1 month ago (2016-11-11 10:47:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494753003/1
4 years, 1 month ago (2016-11-11 10:53:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/17719) v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 11:22:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494753003/20001
4 years, 1 month ago (2016-11-11 11:47:19 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/12003) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 12:01:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494753003/40001
4 years, 1 month ago (2016-11-11 12:07:26 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 13:04:14 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:39 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d24f1aefa89a8fe691d7820e39e424eef407df4
Cr-Commit-Position: refs/heads/master@{#40923}

Powered by Google App Engine
This is Rietveld 408576698