[heap] Record pretenuring feedback for moved pages

[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=chromium:651354
Committed: https://crrev.com/5af14e24824676e2fbe68bac6500f05d3b20368a
Cr-Commit-Position: refs/heads/master@{#40905}

[Michael Lippautz, 2016-11-10 14:03:09]

Description was changed from

==========
[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=
==========

to

==========
[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=chromium:651354
==========

[Michael Lippautz, 2016-11-10 14:03:09]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org, ulan@chromium.org

[Michael Lippautz, 2016-11-10 14:06:02]

https://codereview.chromium.org/2494723002/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2494723002/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:3010: success = collector_->VisitLiveObjects(page,
&new_space_page_visitor,
Measured the impact on ToT splay w/ --gc-global. In this case we go from
0ms->0.2ms for full pages. The minor MC experiment shows that this (or some
variation) will be needed in the future.

[Michael Lippautz, 2016-11-10 14:59:56]

As suggested offline, I restructured to using templates.

[ulan, 2016-11-10 15:16:09]

lgtm

[Michael Lippautz, 2016-11-10 15:22:57]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 15:23:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 15:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 15:43:12]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16021)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/17527)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[Michael Lippautz, 2016-11-10 15:44:09]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 15:44:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-11-10 15:52:27]

https://codereview.chromium.org/2494723002/diff/60001/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):

https://codereview.chromium.org/2494723002/diff/60001/src/heap/heap-inl.h#old...
src/heap/heap-inl.h:634: DCHECK(InFromSpace(object));
why do you have to remove this check? it should still hold?

[Michael Lippautz, 2016-11-10 16:03:29]

https://codereview.chromium.org/2494723002/diff/60001/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):

https://codereview.chromium.org/2494723002/diff/60001/src/heap/heap-inl.h#old...
src/heap/heap-inl.h:634: DCHECK(InFromSpace(object));
On 2016/11/10 15:52:26, Hannes Payer wrote:
> why do you have to remove this check? it should still hold?

Object can now be in ToSpace, FromSpace, or even old space. Created a new DCHECK
which precisely checks when it should be where.

[Michael Lippautz, 2016-11-10 16:09:31]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 16:09:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-11-10 16:09:46]

LGTM. With two more nits.

https://codereview.chromium.org/2494723002/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2494723002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1847: static void Move(Page* page, PagedSpace*
new_owner = nullptr) {
I do not need the both the mode and the new_owner. Because a new space pages
stays a new space page, or it moves to old space. Having one is good enough to
tell. I would remove one.

https://codereview.chromium.org/2494723002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3010: DCHECK(success);
move up DCHECK one line to be in sync with the preceding code.

[Michael Lippautz, 2016-11-10 16:20:29]

Thanks a lot

https://codereview.chromium.org/2494723002/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2494723002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1847: static void Move(Page* page, PagedSpace*
new_owner = nullptr) {
On 2016/11/10 16:09:46, Hannes Payer wrote:
> I do not need the both the mode and the new_owner. Because a new space pages
> stays a new space page, or it moves to old space. Having one is good enough to
> tell. I would remove one.

Done.

https://codereview.chromium.org/2494723002/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3010: DCHECK(success);
On 2016/11/10 16:09:46, Hannes Payer wrote:
> move up DCHECK one line to be in sync with the preceding code.

Done.

[Michael Lippautz, 2016-11-10 16:20:36]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 16:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 16:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 16:23:29]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15990)

[Michael Lippautz, 2016-11-10 16:41:56]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-11-10 16:41:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2494723002/#ps140001
(title: "Fix comilaton issue")

[commit-bot: I haz the power, 2016-11-10 16:42:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 17:10:53]

Description was changed from

==========
[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=chromium:651354
==========

to

==========
[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=chromium:651354
==========

[commit-bot: I haz the power, 2016-11-10 17:10:54]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-17 22:29:49]

Description was changed from

==========
[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=chromium:651354
==========

to

==========
[heap] Record pretenuring feedback for moved pages

Record feedback for moved pages. Aligns the behavior of the copying and moving
evacuator.

BUG=chromium:651354

Committed: https://crrev.com/5af14e24824676e2fbe68bac6500f05d3b20368a
Cr-Commit-Position: refs/heads/master@{#40905}
==========

[commit-bot: I haz the power, 2016-11-17 22:29:51]

Patchset 8 (id:??) landed as
https://crrev.com/5af14e24824676e2fbe68bac6500f05d3b20368a
Cr-Commit-Position: refs/heads/master@{#40905}