Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: telemetry/telemetry/page/__init__.py

Issue 2494713004: Add traffic setting as a grouping key (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/__init__.py
diff --git a/telemetry/telemetry/page/__init__.py b/telemetry/telemetry/page/__init__.py
index 880a076f36264a6996c7e160f40f9bceb96fd1af..2d587fc6991c7d3c014bb83a5e20fdc1716f6bcd 100644
--- a/telemetry/telemetry/page/__init__.py
+++ b/telemetry/telemetry/page/__init__.py
@@ -50,6 +50,8 @@ class Page(story.Story):
self._cache_temperature = cache_temperature
if cache_temperature != cache_temperature_module.ANY:
self.grouping_keys['cache_temperature'] = cache_temperature
+ if traffic_setting != traffic_setting_module.NONE:
+ self.grouping_keys['traffic_setting'] = traffic_setting
assert traffic_setting in traffic_setting_module.NETWORK_CONFIGS, (
'Invalid traffic setting: %s' % traffic_setting)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698