Reenable Tabdragging tests failing because of IsWindowPositionManaged()

ash/wm/toplevel_window_event_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/toplevel_window_event_handler.h"
 
 #include "ash/common/wm/window_state.h"
 #include "ash/common/wm/workspace_controller.h"
 #include "ash/public/cpp/shell_window_ids.h"
 #include "ash/root_window_controller.h"
@@ skipping 60 matching lines @@
     w1->Init(ui::LAYER_TEXTURED);
     aura::Window* parent = Shell::GetContainer(Shell::GetPrimaryRootWindow(),
                                                kShellWindowId_DefaultContainer);
     parent->AddChild(w1);
     w1->SetBounds(gfx::Rect(0, 0, 100, 100));
     w1->Show();
     return w1;
   }
 
   void DragFromCenterBy(aura::Window* window, int dx, int dy) {
+    wm::WindowState* window_state = ash::wm::GetWindowState(window);
+    const bool initial_window_position_managed =
+        window_state->window_position_managed();

[Mr4D (OOO till 08-26), 2016/11/28 19:32:56]

I might be mistaken, but is there any case where this returns true? You might
want to add a unit test which adds a case where this could be tested.

[afakhry, 2016/11/28 22:54:25]

Thanks for this note. Actually this test is not very accurate. I need to verify
that window position auto management is disabled inside the move run loop.
Please take a look at the new test I added.

+
     ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(), window);
-    generator.DragMouseBy(dx, dy);
+    generator.PressLeftButton();
+    generator.MoveMouseBy(dx, dy);
+
+    // Window position auto management should be disabled during the drag.
+    EXPECT_FALSE(window_state->window_position_managed());
+
+    generator.ReleaseLeftButton();
+
+    // And restored to its original value after the drag is complete.
+    EXPECT_EQ(initial_window_position_managed,
+              window_state->window_position_managed());
   }
 
   void TouchDragFromCenterBy(aura::Window* window, int dx, int dy) {
     ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(), window);
     generator.PressMoveAndReleaseTouchBy(dx, dy);
   }
 
   std::unique_ptr<ToplevelWindowEventHandler> handler_;
 
  private:
@@ skipping 667 matching lines @@
   EXPECT_EQ(aura::client::MOVE_SUCCESSFUL,
             move_client->RunMoveLoop(window.get(), gfx::Vector2d(),
                                      aura::client::WINDOW_MOVE_SOURCE_TOUCH));
 }
 
 // Showing the resize shadows when the mouse is over the window edges is tested
 // in resize_shadow_and_cursor_test.cc
 
 }  // namespace test
 }  // namespace ash