Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2494703002: [crankshaft] Not all HAdd instructions produce a number. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Not all HAdd instructions produce a number. BUG=chromium:664084 R=jarin@chromium.org Committed: https://crrev.com/6d533403f9285e61927300c8a9bc4de00cf467b3 Cr-Commit-Position: refs/heads/master@{#40894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 2 chunks +4 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-664084.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-10 12:42:09 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-11-10 13:07:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494703002/1
4 years, 1 month ago (2016-11-10 13:08:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 13:11:20 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d533403f9285e61927300c8a9bc4de00cf467b3
Cr-Commit-Position: refs/heads/master@{#40894}

Powered by Google App Engine
This is Rietveld 408576698