Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2494683007: Fix sevg above CPDF_PageContentGenerator::ProcessImage() (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix sevg above CPDF_PageContentGenerator::ProcessImage() Adds a test to process an image for which a stream hasn't been set. BUG=660756 Committed: https://pdfium.googlesource.com/pdfium/+/5937d0d03793caf73c8bb795ac06684596790e82

Patch Set 1 #

Patch Set 2 : Early return #

Patch Set 3 : Use IsInline() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp View 1 2 1 chunk +14 lines, -9 lines 0 comments Download
M fpdfsdk/fpdfeditimg_unittest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Tom Sepez
Lei, for review. This supersedes the previous CL, since the fix is far simpler than ...
4 years, 1 month ago (2016-11-11 17:12:53 UTC) #5
Tom Sepez
On 2016/11/11 17:12:53, Tom Sepez wrote: > Lei, for review. This supersedes the previous CL, ...
4 years, 1 month ago (2016-11-11 18:53:38 UTC) #8
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-11 19:52:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494683007/40001
4 years, 1 month ago (2016-11-11 20:05:12 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 20:05:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/5937d0d03793caf73c8bb795ac0668459679...

Powered by Google App Engine
This is Rietveld 408576698