Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2494673002: [turbofan] Introduce map-guarded generic handler for named store. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce map-guarded generic handler for named store. This helps if the polymorhpic case has other maps with fast accesses. In box2d (with high number of iterations and warm-up), we spend about 2.7% of running time in StoreIC; after this change it is only 0.2%. Committed: https://crrev.com/225cb9fadf3c88909719645e8f93f23bfbbe2961 Cr-Commit-Position: refs/heads/master@{#40957}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment, fix the keyed store IC case #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -27 lines) Patch
M src/compiler/access-info.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/compiler/access-info.cc View 1 2 3 chunks +16 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 4 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 9 chunks +51 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-10 08:05:55 UTC) #5
Benedikt Meurer
LGTM % nexus. https://codereview.chromium.org/2494673002/diff/1/src/compiler/js-native-context-specialization.h File src/compiler/js-native-context-specialization.h (right): https://codereview.chromium.org/2494673002/diff/1/src/compiler/js-native-context-specialization.h#newcode81 src/compiler/js-native-context-specialization.h:81: FeedbackNexus const& nexus, Please pass vector+slot ...
4 years, 1 month ago (2016-11-10 08:10:05 UTC) #6
Benedikt Meurer
LGTM, thanks.
4 years, 1 month ago (2016-11-13 18:38:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494673002/40001
4 years, 1 month ago (2016-11-14 09:48:24 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-14 10:47:19 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:13 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/225cb9fadf3c88909719645e8f93f23bfbbe2961
Cr-Commit-Position: refs/heads/master@{#40957}

Powered by Google App Engine
This is Rietveld 408576698