Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2494663004: Mus+Ash: ServerWindowCompositorFrameSink => GpuCompositorFrameSink (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus+Ash: ServerWindowCompositorFrameSink => GpuCompositorFrameSink The thing that is currently called ServerWindowCompositorFrameSink doesn't know and shouldn't know anything about ServerWindows because it'll live in the GPU process. This CL renames the class to better capture this requirement. BUG=661278 Committed: https://crrev.com/16700579f33d11511d05966bc1c42f0b90bacd8d Cr-Commit-Position: refs/heads/master@{#431514}

Patch Set 1 #

Patch Set 2 : ServerWindow no longer depends on GpuCompositorFrameSink #

Patch Set 3 : Removed dependency on GpuCompositorFrameSink in window_finder #

Patch Set 4 : ServerWindowCompositorFrameSinkManager should not reference SurfaceFactory or SurfaceManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -419 lines) Patch
M services/ui/ws/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + services/ui/ws/gpu_compositor_frame_sink.h View 5 chunks +15 lines, -16 lines 0 comments Download
A + services/ui/ws/gpu_compositor_frame_sink.cc View 10 chunks +20 lines, -24 lines 0 comments Download
M services/ui/ws/server_window.h View 1 1 chunk +5 lines, -1 line 0 comments Download
D services/ui/ws/server_window_compositor_frame_sink.h View 1 chunk +0 lines, -140 lines 0 comments Download
D services/ui/ws/server_window_compositor_frame_sink.cc View 1 chunk +0 lines, -225 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M services/ui/ws/window_finder.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Fady Samuel
+sky@ for OWNERS +sadrul@ FYI
4 years, 1 month ago (2016-11-10 22:18:31 UTC) #2
sky
LGTM
4 years, 1 month ago (2016-11-11 00:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494663004/40001
4 years, 1 month ago (2016-11-11 00:53:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/335382)
4 years, 1 month ago (2016-11-11 01:22:05 UTC) #7
sadrul
lgtm (X.h has a #define for DestroyAll(). That's what's causing the build issues)
4 years, 1 month ago (2016-11-11 01:46:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494663004/60001
4 years, 1 month ago (2016-11-11 05:00:56 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-11 07:08:53 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 07:13:15 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/16700579f33d11511d05966bc1c42f0b90bacd8d
Cr-Commit-Position: refs/heads/master@{#431514}

Powered by Google App Engine
This is Rietveld 408576698