Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 2494663002: WebRTC: Use slave_build dir instead of working dir for symlink cleaning. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 from recipe_engine import recipe_api 6 from recipe_engine import recipe_api
7 from . import builders 7 from . import builders
8 from . import steps 8 from . import steps
9 9
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 def checkout(self, **kwargs): 177 def checkout(self, **kwargs):
178 self._working_dir = self.m.chromium_checkout.get_checkout_dir({}) 178 self._working_dir = self.m.chromium_checkout.get_checkout_dir({})
179 if self._working_dir: 179 if self._working_dir:
180 kwargs.setdefault('cwd', self._working_dir) 180 kwargs.setdefault('cwd', self._working_dir)
181 181
182 # TODO(kjellander): Deploy at all bots once verified working. 182 # TODO(kjellander): Deploy at all bots once verified working.
183 if self.mastername == 'client.webrtc.fyi': 183 if self.mastername == 'client.webrtc.fyi':
184 # Cleanup symlinks if there are any created. 184 # Cleanup symlinks if there are any created.
185 self.m.python('clean symlinks', 185 self.m.python('clean symlinks',
186 script=self.resource('cleanup_symlinks.py'), 186 script=self.resource('cleanup_symlinks.py'),
187 args=[self._working_dir], 187 args=[self.m.path['slave_build']],
188 infra_step=True) 188 infra_step=True)
189 189
190 update_step = self.m.bot_update.ensure_checkout(**kwargs) 190 update_step = self.m.bot_update.ensure_checkout(**kwargs)
191 assert update_step.json.output['did_run'] 191 assert update_step.json.output['did_run']
192 192
193 # Whatever step is run right before this line needs to emit got_revision. 193 # Whatever step is run right before this line needs to emit got_revision.
194 revs = update_step.presentation.properties 194 revs = update_step.presentation.properties
195 self.revision = revs['got_revision'] 195 self.revision = revs['got_revision']
196 self.revision_cp = revs['got_revision_cp'] 196 self.revision_cp = revs['got_revision_cp']
197 self.revision_number = str(self.m.commit_position.parse_revision( 197 self.revision_number = str(self.m.commit_position.parse_revision(
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 def clean_test_output(self): 377 def clean_test_output(self):
378 """Remove all test output in out/, since we have tests leaking files.""" 378 """Remove all test output in out/, since we have tests leaking files."""
379 out_dir = self.m.path['checkout'].join('out') 379 out_dir = self.m.path['checkout'].join('out')
380 self.m.python('clean test output files', 380 self.m.python('clean test output files',
381 script=self.resource('cleanup_files.py'), 381 script=self.resource('cleanup_files.py'),
382 args=[out_dir], 382 args=[out_dir],
383 infra_step=True) 383 infra_step=True)
384 384
385 def virtual_webcam_check(self): 385 def virtual_webcam_check(self):
386 self.m.python('webcam_check', self.resource('ensure_webcam_is_running.py')) 386 self.m.python('webcam_check', self.resource('ensure_webcam_is_running.py'))
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698