Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/json_schema_compiler/test/features_generation_unittest.cc

Issue 2494653005: Support API aliases (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/features_generation_unittest.cc
diff --git a/tools/json_schema_compiler/test/features_generation_unittest.cc b/tools/json_schema_compiler/test/features_generation_unittest.cc
index 25f6bcc478bf57de3d730b260d56249c3ff3ad3a..3b7e8e13ab961a60012495a2849c85cd8bd73c76 100644
--- a/tools/json_schema_compiler/test/features_generation_unittest.cc
+++ b/tools/json_schema_compiler/test/features_generation_unittest.cc
@@ -53,6 +53,8 @@ struct FeatureComparator {
std::string command_line_switch;
std::unique_ptr<version_info::Channel> channel;
bool internal;
+ std::string alias;
+ std::string source;
};
FeatureComparator::FeatureComparator(const std::string& name)
@@ -86,6 +88,8 @@ void FeatureComparator::CompareFeature(SimpleFeature* feature) {
if (channel)
EXPECT_EQ(*channel, feature->channel()) << name;
EXPECT_EQ(internal, feature->IsInternal()) << name;
+ EXPECT_EQ(alias, feature->alias()) << name;
+ EXPECT_EQ(source, feature->source()) << name;
}
TEST(FeaturesGenerationTest, FeaturesTest) {
@@ -262,6 +266,61 @@ TEST(FeaturesGenerationTest, FeaturesTest) {
comparator.CompareFeature(other_parent);
}
}
+
+ // Test API aliases.
+ {
+ APIFeature* feature = GetAPIFeature("alias");
+ FeatureComparator comparator("alias");
+ comparator.contexts = {Feature::BLESSED_EXTENSION_CONTEXT};
+ comparator.channel.reset(
+ new version_info::Channel(version_info::Channel::STABLE));
+ comparator.source = "alias_source";
+ comparator.CompareFeature(feature);
+ }
+ {
+ APIFeature* feature = GetAPIFeature("alias_source");
+ FeatureComparator comparator("alias_source");
+ comparator.contexts = {Feature::BLESSED_EXTENSION_CONTEXT};
+ comparator.channel.reset(
+ new version_info::Channel(version_info::Channel::STABLE));
+ comparator.alias = "alias";
+ comparator.CompareFeature(feature);
+ }
+ {
+ Feature* feature = GetAPIFeature("complex_alias");
+ ASSERT_EQ("", feature->alias());
+ ASSERT_EQ("complex_alias_source", feature->source());
+ }
+ {
+ Feature* feature = GetAPIFeature("complex_alias_source");
+ ASSERT_EQ("complex_alias", feature->alias());
+ ASSERT_EQ("", feature->source());
+ }
+ {
+ Feature* feature = GetAPIFeature("parent_source");
+ ASSERT_EQ("parent_source_alias", feature->alias());
+ ASSERT_EQ("", feature->source());
+ }
+ {
+ Feature* feature = GetAPIFeature("parent_source.child");
+ ASSERT_EQ("parent_source_alias", feature->alias());
+ ASSERT_EQ("", feature->source());
+ }
+ {
+ Feature* feature = GetAPIFeature("parent_source.child_source");
+ ASSERT_EQ("parent_source_child_alias", feature->alias());
+ ASSERT_EQ("", feature->source());
+ }
+ {
+ Feature* feature = GetAPIFeature("alias_parent");
+ ASSERT_EQ("", feature->alias());
+ ASSERT_EQ("", feature->source());
+ }
+ {
+ Feature* feature = GetAPIFeature("alias_parent.child");
+ ASSERT_EQ("", feature->alias());
+ ASSERT_EQ("child_source", feature->source());
+ }
}
} // namespace extensions
« no previous file with comments | « tools/json_schema_compiler/feature_compiler_test.py ('k') | tools/json_schema_compiler/test/features_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698