extensions/renderer/native_extension_bindings_system.cc - Issue 2494653005: Support API aliases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/native_extension_bindings_system.cc

Issue 2494653005: Support API aliases (Closed)

Patch Set: Fix issue with child features not being able to override parent shared values Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/native_extension_bindings_system.cc

diff --git a/extensions/renderer/native_extension_bindings_system.cc b/extensions/renderer/native_extension_bindings_system.cc

index 7e56635dfbfc03d70f5b53d37d5994b2b784d616..d0b223463d7c0de70bc84c9b08800eb171f6f6b0 100644

--- a/extensions/renderer/native_extension_bindings_system.cc

+++ b/extensions/renderer/native_extension_bindings_system.cc

@@ -124,7 +124,8 @@ void NativeExtensionBindingsSystem::UpdateBindingsForContext(

continue;

}

- if (!context->IsAnyFeatureAvailableToContext(*map_entry.second))

+ if (!context->IsAnyFeatureAvailableToContext(*map_entry.second,

+ CheckAliasStatus::NOT_ALLOWED))

continue;

// TODO(devlin): Make this lazy by adding a getter.