Support API aliases

extensions/common/extension_api.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EXTENSION_API_H_
 #define EXTENSIONS_COMMON_EXTENSION_API_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 68 matching lines @@
   // Returns true if the API item called |api_full_name| and all of its
   // dependencies are available in |context|.
   //
   // |api_full_name| can be either a namespace name (like "bookmarks") or a
   // member name (like "bookmarks.create").
   //
   // Depending on the configuration of |api| (in _api_features.json), either
   // |extension| or |url| (or both) may determine its availability, but this is
   // up to the configuration of the individual feature.
   //
+  // |allow_alias| determines whether it should be tested whether the API
+  // is available through an alias.
+  //
   // TODO(kalman): This is just an unnecessary combination of finding a Feature
   // then calling Feature::IsAvailableToContext(..) on it. Just provide that
   // FindFeature function and let callers compose if they want.
   Feature::Availability IsAvailable(const std::string& api_full_name,
                                     const Extension* extension,
                                     Feature::Context context,
-                                    const GURL& url);
+                                    const GURL& url,
+                                    bool allow_alias);

[Devlin, 2016/11/14 18:03:56]

I think this would be more clear with an enum, ALLOW_ALIASES/DONT_ALLOW_ALIASES.
 Anonymous bools in permission checks are something I'd prefer to avoid.

[tbarzic, 2016/11/15 04:45:07]

Done.

 
-  // Determines whether an API, or any parts of that API, are available in
+  // Determines whether an API, or any parts of that API, can be exposed to
   // |context|.
+  //
+  // |allow_alias| determines whether it should be tested whether the API
+  // is available through an alias.
+  //
   bool IsAnyFeatureAvailableToContext(const Feature& api,
                                       const Extension* extension,
                                       Feature::Context context,
-                                      const GURL& url);
+                                      const GURL& url,
+                                      bool allow_alias);

[Devlin, 2016/11/14 18:03:56]

ditto

[tbarzic, 2016/11/15 04:45:07]

Done.

 
   // Gets the StringPiece for the schema specified by |api_name|.
   base::StringPiece GetSchemaStringPiece(const std::string& api_name);
 
   // Gets the schema for the extension API with namespace |full_name|.
   // Ownership remains with this object.
   // TODO(devlin): Now that we use GetSchemaStringPiece() in the renderer, we
   // may not really need this anymore.
   const base::DictionaryValue* GetSchema(const std::string& full_name);
 
@@ skipping 16 matching lines @@
  private:
   FRIEND_TEST_ALL_PREFIXES(ExtensionAPITest, DefaultConfigurationFeatures);
   friend struct base::DefaultSingletonTraits<ExtensionAPI>;
 
   void InitDefaultConfiguration();
 
   // Returns true if there exists an API with |name|. Declared virtual for
   // testing purposes.
   virtual bool IsKnownAPI(const std::string& name, ExtensionsClient* client);
 
+  // Checks if |full_name| is available to provided context and extension under
+  // associated API's alias name.
+  Feature::Availability IsAliasAvailable(const std::string& full_name,
+                                         Feature* api,
+                                         const Extension* extension,
+                                         Feature::Context context,
+                                         const GURL& url);
+
   bool default_configuration_initialized_;
 
   // Loads a schema.
   void LoadSchema(const std::string& name, const base::StringPiece& schema);
 
   // Schemas for each namespace.
   using SchemaMap =
       std::map<std::string, std::unique_ptr<const base::DictionaryValue>>;
   SchemaMap schemas_;
 
   using StringPieceMap = std::map<std::string, base::StringPiece>;
   StringPieceMap schema_strings_;
 
   // FeatureProviders used for resolving dependencies.
   typedef std::map<std::string, const FeatureProvider*> FeatureProviderMap;
   FeatureProviderMap dependency_providers_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionAPI);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EXTENSION_API_H_