Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3148)

Unified Diff: chrome/test/data/extensions/api_test/executescript/frame_id/test.js

Issue 2494633004: Remove about:srcdoc url conversion. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/executescript/frame_id/test.js
diff --git a/chrome/test/data/extensions/api_test/executescript/frame_id/test.js b/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
index cfd38c71bbfab4ae8d8b8e24e27cd8800440bef8..6fa3f36ce8f0abde9a9b3527e90384f0bd02293b 100644
--- a/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
+++ b/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
@@ -147,12 +147,10 @@ function runTests(config) {
},
function executeScriptInSrcdocFrameWithoutMatchAboutBlank() {
- // TODO(robwu): Why is the origin serialized as "about:blank" instead of
- // "about:srcdoc"?
chrome.tabs.executeScript(
tabId, {frameId: ID_FRAME_SRCDOC, code: 'document.URL'},
fail(
- 'Cannot access "about:blank" at origin "' + testOrigin + '". ' +
+ 'Cannot access "about:srcdoc" at origin "' + testOrigin + '". ' +
'Extension must have permission to access the frame\'s origin, ' +
'and matchAboutBlank must be true.'));
},
@@ -283,12 +281,10 @@ function runTests(config) {
},
function insertCSSInSrcdocFrameWithoutMatchAboutBlank() {
- // TODO(robwu): Why is the origin serialized as "about:blank" instead of
- // "about:srcdoc"?
chrome.tabs.insertCSS(
tabId, {frameId: ID_FRAME_SRCDOC, code: 'body{color:red;}'},
fail(
- 'Cannot access "about:blank" at origin "' + testOrigin + '". ' +
+ 'Cannot access "about:srcdoc" at origin "' + testOrigin + '". ' +
'Extension must have permission to access the frame\'s origin, ' +
'and matchAboutBlank must be true.'));
},
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_ui.cc ('k') | components/dom_distiller/content/browser/distillability_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698