content/browser/child_process_security_policy_unittest.cc - Issue 2494633004: Remove about:srcdoc url conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_security_policy_unittest.cc

Issue 2494633004: Remove about:srcdoc url conversion. (Closed)

Patch Set: Addressed comments (@creis) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/child_process_security_policy_unittest.cc

diff --git a/content/browser/child_process_security_policy_unittest.cc b/content/browser/child_process_security_policy_unittest.cc

index 00138f23483e23492b3a9dcc5f2dfba4176e481d..fb171a8112d219c8f24c54697ba24d87b535e976 100644

--- a/content/browser/child_process_security_policy_unittest.cc

+++ b/content/browser/child_process_security_policy_unittest.cc

@@ -261,16 +261,16 @@ TEST_F(ChildProcessSecurityPolicyTest, AboutTest) {

p->Add(kRendererID);

EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("about:blank")));

- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("about:BlAnK")));

- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("aBouT:BlAnK")));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:BlAnK")));

+ EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("aBouT:BlAnK")));

EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("aBouT:blank")));

EXPECT_TRUE(p->CanCommitURL(kRendererID, GURL("about:blank")));

- EXPECT_TRUE(p->CanCommitURL(kRendererID, GURL("about:BlAnK")));

- EXPECT_TRUE(p->CanCommitURL(kRendererID, GURL("aBouT:BlAnK")));

+ EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("about:BlAnK")));

+ EXPECT_FALSE(p->CanCommitURL(kRendererID, GURL("aBouT:BlAnK")));

EXPECT_TRUE(p->CanCommitURL(kRendererID, GURL("aBouT:blank")));

EXPECT_TRUE(p->CanSetAsOriginHeader(kRendererID, GURL("about:blank")));

- EXPECT_TRUE(p->CanSetAsOriginHeader(kRendererID, GURL("about:BlAnK")));

- EXPECT_TRUE(p->CanSetAsOriginHeader(kRendererID, GURL("aBouT:BlAnK")));

+ EXPECT_FALSE(p->CanSetAsOriginHeader(kRendererID, GURL("about:BlAnK")));

+ EXPECT_FALSE(p->CanSetAsOriginHeader(kRendererID, GURL("aBouT:BlAnK")));

EXPECT_TRUE(p->CanSetAsOriginHeader(kRendererID, GURL("aBouT:blank")));

Charlie Reis 2016/11/23 08:25:21 Can you add some cases for about:srcdoc?

arthursonzogni 2016/11/23 14:39:26 Done.

EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:crash")));