Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Unified Diff: content/browser/site_instance_impl.cc

Issue 2494633004: Remove about:srcdoc url conversion. (Closed)
Patch Set: Fix tests with about::blank Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl.cc
diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc
index 7980783a7d3ed0acfe3da00d14a192471abd8e75..83547cd7748094d1388fab96fb516e939d2d8da1 100644
--- a/content/browser/site_instance_impl.cc
+++ b/content/browser/site_instance_impl.cc
@@ -316,10 +316,9 @@ bool SiteInstance::IsSameWebSite(BrowserContext* browser_context,
if (!src_url.is_valid() || !dest_url.is_valid())
return false;
- // If the destination url is just a blank page, we treat them as part of the
- // same site.
- GURL blank_page(url::kAboutBlankURL);
- if (dest_url == blank_page)
+ // If the destination url is just about:blank or about:srcdoc, we treat them
+ // as part of the same site.
+ if (dest_url == url::kAboutBlankURL || dest_url == content::kAboutSrcDocURL)
Charlie Reis 2016/11/22 01:01:20 Let's leave this out. As I mentioned in a previou
arthursonzogni 2016/11/22 16:43:27 I add a test in a separate CL: https://codereview.
return true;
// If the schemes differ, they aren't part of the same site.

Powered by Google App Engine
This is Rietveld 408576698