chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java - Issue 2494633004: Remove about:srcdoc url conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2494633004: Remove about:srcdoc url conversion. (Closed)

Patch Set: Addressed comments (@creis) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java ('k') | chrome/browser/extensions/api/web_navigation/frame_navigation_state.h » ('j') | chrome/browser/history/history_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

index dc426e1ebff4f91d3e6d25c4a9173c9a0ac4beae..acfdc9e0807b3b2256425287f0917971553c8cec 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

@@ -185,8 +185,7 @@ public class TabWebContentsObserver extends WebContentsObserver {

@Override

public void didStartProvisionalLoadForFrame(long frameId, long parentFrameId,

- boolean isMainFrame, String validatedUrl, boolean isErrorPage,

- boolean isIframeSrcdoc) {

+ boolean isMainFrame, String validatedUrl, boolean isErrorPage) {

if (isMainFrame) mTab.didStartPageLoad(validatedUrl, isErrorPage);

mTab.handleDidStartProvisionalLoadForFrame(isMainFrame, validatedUrl);