Chromium Code Reviews| Index: content/browser/frame_host/navigation_entry_impl.cc |
| diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc |
| index b450e8ec3ae6cf7ba5397ba32c8053193cd522e2..10006cc69b4ab933271e06db2c8a8375137c6f29 100644 |
| --- a/content/browser/frame_host/navigation_entry_impl.cc |
| +++ b/content/browser/frame_host/navigation_entry_impl.cc |
| @@ -875,21 +875,7 @@ std::map<std::string, bool> NavigationEntryImpl::GetSubframeUniqueNames( |
| // renderer should be allowed to just commit the initial blank frame if |
| // that was the default URL. PageState doesn't matter there, because |
| // content injected into about:blank frames doesn't use it. |
| - // |
| - // Be careful not to include iframe srcdoc URLs in this check, which do |
|
nasko
2016/11/10 18:14:14
I really like this cleanup!
Charlie Reis
2016/11/11 22:53:24
+1!
|
| - // need their PageState. The committed URL in that case gets rewritten to |
| - // about:blank, but we can detect it via the PageState's URL. |
| - // |
| - // See https://crbug.com/657896 for details. |
| - bool is_about_blank = false; |
| - ExplodedPageState exploded_page_state; |
| - if (DecodePageState(child->frame_entry->page_state().ToEncodedData(), |
| - &exploded_page_state)) { |
| - ExplodedFrameState frame_state = exploded_page_state.top; |
| - if (UTF16ToUTF8(frame_state.url_string.string()) == url::kAboutBlankURL) |
| - is_about_blank = true; |
| - } |
| - |
| + bool is_about_blank = (child->frame_entry->url() == url::kAboutBlankURL); |
|
nasko
2016/11/10 18:14:14
Why even declare the boolean here, just use the ex
arthursonzogni
2016/11/15 16:37:08
Done.
|
| names[child->frame_entry->frame_unique_name()] = is_about_blank; |
| } |
| } |