Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: content/public/browser/web_contents_observer.h

Issue 2494633004: Remove about:srcdoc url conversion. (Closed)
Patch Set: Addressed comments (@nasko). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 // SOON TO BE DEPRECATED. Use DidStartNavigation instead in PlzNavigate. In 193 // SOON TO BE DEPRECATED. Use DidStartNavigation instead in PlzNavigate. In
194 // default mode, it is still necessary to override this function to be 194 // default mode, it is still necessary to override this function to be
195 // notified about a navigation earlier than DidStartProvisionalLoad. This 195 // notified about a navigation earlier than DidStartProvisionalLoad. This
196 // function will be removed when PlzNavigate is enabled. 196 // function will be removed when PlzNavigate is enabled.
197 virtual void DidStartNavigationToPendingEntry(const GURL& url, 197 virtual void DidStartNavigationToPendingEntry(const GURL& url,
198 ReloadType reload_type) {} 198 ReloadType reload_type) {}
199 199
200 // |render_frame_host| is the RenderFrameHost for which the provisional load 200 // |render_frame_host| is the RenderFrameHost for which the provisional load
201 // is happening. 201 // is happening.
202 // 202 //
203 // Since the URL validation will strip error URLs, or srcdoc URLs, the boolean 203 // Since the URL validation will strip error URLs, the boolean flags
Charlie Reis 2016/11/16 18:20:22 nit: flag
arthursonzogni 2016/11/17 17:04:58 Done.
204 // flags |is_error_page| and |is_iframe_srcdoc| will indicate that the not 204 // |is_error_page| will indicate that the not validated URL was an error page.
205 // validated URL was either an error page or an iframe srcdoc.
206 // 205 //
207 // Note that during a cross-process navigation, several provisional loads 206 // Note that during a cross-process navigation, several provisional loads
208 // can be on-going in parallel. 207 // can be on-going in parallel.
209 // 208 //
210 // DEPRECATED. Use DidStartNavigation instead in all cases. 209 // DEPRECATED. Use DidStartNavigation instead in all cases.
211 virtual void DidStartProvisionalLoadForFrame( 210 virtual void DidStartProvisionalLoadForFrame(
212 RenderFrameHost* render_frame_host, 211 RenderFrameHost* render_frame_host,
213 const GURL& validated_url, 212 const GURL& validated_url,
214 bool is_error_page, 213 bool is_error_page) {}
215 bool is_iframe_srcdoc) {}
216 214
217 // This method is invoked when the provisional load was successfully 215 // This method is invoked when the provisional load was successfully
218 // committed. 216 // committed.
219 // 217 //
220 // If the navigation only changed the reference fragment, or was triggered 218 // If the navigation only changed the reference fragment, or was triggered
221 // using the history API (e.g. window.history.replaceState), we will receive 219 // using the history API (e.g. window.history.replaceState), we will receive
222 // this signal without a prior DidStartProvisionalLoadForFrame signal. 220 // this signal without a prior DidStartProvisionalLoadForFrame signal.
223 // 221 //
224 // DEPRECATED. Use DidFinishNavigation instead in all cases. 222 // DEPRECATED. Use DidFinishNavigation instead in all cases.
225 virtual void DidCommitProvisionalLoadForFrame( 223 virtual void DidCommitProvisionalLoadForFrame(
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 void ResetWebContents(); 505 void ResetWebContents();
508 506
509 WebContentsImpl* web_contents_; 507 WebContentsImpl* web_contents_;
510 508
511 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver); 509 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);
512 }; 510 };
513 511
514 } // namespace content 512 } // namespace content
515 513
516 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 514 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698