Remove about:srcdoc url conversion.

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 1383 matching lines @@
   // chrome://crash, however.
   // TODO(creis): Refactor this method so this duplicated code isn't needed.
   // See http://crbug.com/123007.
   if (current_entry &&
       current_entry->IsViewSourceMode() != dest_is_view_source_mode &&
       !IsRendererDebugURL(dest_url)) {
     return SiteInstanceDescriptor(browser_context, dest_url,
                                   SiteInstanceRelation::UNRELATED);
   }
 
-  // Use the source SiteInstance in case of data URLs or about:blank pages,
-  // because the content is then controlled and/or scriptable by the source
-  // SiteInstance.
+  // Use the source SiteInstance in case of data URLs, about:srcdoc pages and
+  // about:blank pages because the content is then controlled and/or scriptable
+  // by the source SiteInstance.
   GURL about_blank(url::kAboutBlankURL);
-  if (source_instance &&
-      (dest_url == about_blank || dest_url.scheme() == url::kDataScheme)) {
+  GURL about_srcdoc(content::kAboutSrcDocURL);
+  if (source_instance && (dest_url == about_srcdoc || dest_url == about_blank ||

[Charlie Reis, 2016/11/11 22:53:24]

Good catch-- that seems right to me.  (I suppose there's a risk of regressing
other similar logic that we don't remember to fix, but maybe that's ok.)

[arthursonzogni, 2016/11/15 16:37:09]

FYI, this modification fixes the test:
FrameTreeBrowserTest.ChildFrameWithSrcdoc
with the --site-per-process flag.

I hope there won't be serious regression.
I tried to find other place where the same kind of modifications may apply, but
since there is no failing tests, it is harder to understand what should be done.

Probably here:
https://cs.chromium.org/chromium/src/chrome/browser/history/history_utils.cc?...

Maybe not here (it is on the renderer side):
https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?cl...
https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?cl...

[Charlie Reis, 2016/11/16 18:20:22]

I'm not sure if that ever gets called for subframes.  I suppose it wouldn't hurt
to add it, though, just in case.
Agreed that it shouldn't matter on the renderer side, since it never rewrote
about:srcdoc to about:blank in the first place (though apparently the code has
changed and those links don't appear to work).

Besides those, there's a chance that it's relevant to
SiteInstanceImpl::IsSameWebSite, but I think the change you're making here is
actually the right way to handle that one.

+                          dest_url.scheme() == url::kDataScheme)) {
     return SiteInstanceDescriptor(source_instance);
   }
 
   // Use the current SiteInstance for same site navigations.
   if (IsCurrentlySameSite(render_frame_host_.get(), dest_url))
     return SiteInstanceDescriptor(render_frame_host_->GetSiteInstance());
 
   if (SiteIsolationPolicy::IsTopDocumentIsolationEnabled()) {
     // TODO(nick): Looking at the main frame and openers is required for TDI
     // mode, but should be safe to enable unconditionally.
@@ skipping 1302 matching lines @@
                                              resolved_url)) {
     DCHECK(!dest_instance ||
            dest_instance == render_frame_host_->GetSiteInstance());
     return false;
   }
 
   return true;
 }
 
 }  // namespace content