Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2494603002: [wasm] cctest - explicit WriteOneByte null termination opt-out (Closed)

Created:
4 years, 1 month ago by Mircea Trofin
Modified:
4 years, 1 month ago
Reviewers:
gdeepti, bradnelson, bradn
CC:
v8-reviews_googlegroups.com, gdeepti
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] cctest - explicit WriteOneByte null termination opt-out Turns out WriteOneByte writes '\0' by default. BUG= Committed: https://crrev.com/5657433e575e038fcb6fa75571bd75f230a028ac Cr-Commit-Position: refs/heads/master@{#40873}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Mircea Trofin
PTAL Deepti - Patch 1 has your change, too, validating mine is a fix. Patch ...
4 years, 1 month ago (2016-11-10 00:34:47 UTC) #7
gdeepti
lgtm Thanks for fixing this! The earlier CL does not need to be committed, as ...
4 years, 1 month ago (2016-11-10 04:37:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494603002/20001
4 years, 1 month ago (2016-11-10 04:51:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 05:17:31 UTC) #13
bradn
lgtm
4 years, 1 month ago (2016-11-10 05:29:09 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5657433e575e038fcb6fa75571bd75f230a028ac
Cr-Commit-Position: refs/heads/master@{#40873}

Powered by Google App Engine
This is Rietveld 408576698