third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl - Issue 2494553002: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl

Issue 2494553002: Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent and expose. (Closed)

Patch Set: Added layout test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html ('K') | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.cpp ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateEvent.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl

similarity index 80%

rename from third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateEvent.idl

rename to third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl

index a9ce7caedaa35f43ba44ac687930381f39910e0d..646aab54e6b2c2dd0d2a24743585caba6d0f6f46 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidateEvent.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionIceEvent.idl

@@ -24,7 +24,9 @@

[

- NoInterfaceObject

-] interface RTCIceCandidateEvent : Event {

- readonly attribute RTCIceCandidate candidate;

+ Constructor(DOMString type, optional RTCPeerConnectionIceEventInit eventInitDict)

+] interface RTCPeerConnectionIceEvent : Event {

+ readonly attribute RTCIceCandidate? candidate;

+ // TODO(lunalu): add nullable url attribute here:

+ // https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#rtcpeerconnectioniceevent

};