Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2494543002: Make android/x64 bot build and run tests in release. (Closed)

Created:
4 years, 1 month ago by Nico
Modified:
4 years, 1 month ago
Reviewers:
bpastene, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make android/x64 bot build and run tests in release. All other testers run tests in release as well. This will help with cycle time, and at least webkit_unit_tests currently fails because one shard times out. (Also, one base_unittest fails in debug but not in release apparently) BUG=534815, 663886 Committed: https://crrev.com/e34cd7cecd15c2bb4290fa9cfc78f1b3f7fef03c Cr-Commit-Position: refs/heads/master@{#431084}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
please hit cq if this looks fine
4 years, 1 month ago (2016-11-09 21:58:10 UTC) #3
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-09 23:41:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494543002/20001
4 years, 1 month ago (2016-11-09 23:42:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 23:47:58 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 23:57:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e34cd7cecd15c2bb4290fa9cfc78f1b3f7fef03c
Cr-Commit-Position: refs/heads/master@{#431084}

Powered by Google App Engine
This is Rietveld 408576698