Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2494493003: Fix ResourceSchedulingFilter crash after ResourceDispatcher deleted (Closed)

Created:
4 years, 1 month ago by alex clarke (OOO till 29th)
Modified:
4 years, 1 month ago
Reviewers:
Mike West, Sami, pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ResourceSchedulingFilter crash after ResourceDispatcher deleted It's possible for the ResourceDispatcher to be deleted after the ResourceSchedulingFilter::DispatchMessage task got posted but before it ran. Plumb a WeakPtr into ResourceSchedulingFilter to avoid a UAF. BUG=664077 Committed: https://crrev.com/77d6eb5f680de17bb02c1496854c59e50099af36 Cr-Commit-Position: refs/heads/master@{#431352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/child/resource_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/resource_scheduling_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
alex clarke (OOO till 29th)
4 years, 1 month ago (2016-11-10 11:34:22 UTC) #6
alex clarke (OOO till 29th)
+Pavel for OWNERS review. Sorry Mike I'd forgotten you don't own content/
4 years, 1 month ago (2016-11-10 11:35:50 UTC) #8
Mike West
On 2016/11/10 at 11:35:50, alexclarke wrote: > +Pavel for OWNERS review. > > Sorry Mike ...
4 years, 1 month ago (2016-11-10 12:33:53 UTC) #9
pfeldman
lgtm
4 years, 1 month ago (2016-11-10 19:23:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494493003/1
4 years, 1 month ago (2016-11-10 21:06:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:11:58 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:23:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77d6eb5f680de17bb02c1496854c59e50099af36
Cr-Commit-Position: refs/heads/master@{#431352}

Powered by Google App Engine
This is Rietveld 408576698