Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: mojo/public/cpp/bindings/pipe_control_message_proxy.h

Issue 2494483003: Mojo Bindings: Fix lock-order inversion in associated controllers (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/pipe_control_message_proxy.h
diff --git a/mojo/public/cpp/bindings/pipe_control_message_proxy.h b/mojo/public/cpp/bindings/pipe_control_message_proxy.h
index 25ee203846915732478fea0ba43c0544979f34cc..f5da26b7493a2f23daec6b1b0ab22dc11a2e0128 100644
--- a/mojo/public/cpp/bindings/pipe_control_message_proxy.h
+++ b/mojo/public/cpp/bindings/pipe_control_message_proxy.h
@@ -15,9 +15,12 @@ namespace mojo {
class MessageReceiver;
// Proxy for request messages defined in pipe_control_messages.mojom.
+//
+// NOTE: This object may be used from multiple threads.
class MOJO_CPP_BINDINGS_EXPORT PipeControlMessageProxy {
public:
- // Doesn't take ownership of |receiver|. It must outlive this object.
+ // Doesn't take ownership of |receiver|. If This PipeControlMessageProxy will
+ // be used from multiple threads, |receiver| must be thread-safe.
explicit PipeControlMessageProxy(MessageReceiver* receiver);
void NotifyPeerEndpointClosed(InterfaceId id);
@@ -26,7 +29,6 @@ class MOJO_CPP_BINDINGS_EXPORT PipeControlMessageProxy {
private:
// Not owned.
MessageReceiver* receiver_;
- internal::SerializationContext context_;
DISALLOW_COPY_AND_ASSIGN(PipeControlMessageProxy);
};
« no previous file with comments | « mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698