build/common.gypi - Issue 249443002: Add helper comment for icecc users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 249443002: Add helper comment for icecc users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change the goal of CL, just comment for new commer. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index df1ae7892cb96eb65d8f4cb6d8cd754e3307aa20..ac734066ee4ba0ad69b5a7c40e2cce21ce993208 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -738,6 +738,8 @@

# be used except on x86 and x86-64 (the only two architectures which

# are currently checke in). Force this off via GYP_DEFINES when you

# are using a custom toolchain and need to control -B in cflags.

+ # Set to 1 when using icecc to avoid incompatible build flags.

+ # https://github.com/icecc/icecream/commit/b2ce5b9cc4bd1900f55c3684214e409fa81e7a92

['OS=="linux" and (target_arch=="x64")', {

'linux_use_bundled_binutils%': 1,

}, {

« no previous file with comments | « no previous file | no next file » | no next file with comments »