Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 249423002: Remove the acceleratedCompositingForAnimationEnabled setting. (Closed)

Created:
6 years, 8 months ago by danakj
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, dglazkov+blink, jchaffraix+rendering, pdr., ojan, rune+blink, enne (OOO), piman
Visibility:
Public.

Description

Remove the acceleratedCompositingForAnimationEnabled setting. This is always on, so we don't need to branch on it. Depends on: https://codereview.chromium.org/239973005/ R=abarth@chromium.org, vollick@chromium.org BUG=366114 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172997

Patch Set 1 #

Patch Set 2 : rm-acceleratedCompositingForAnimationEnabled: #

Patch Set 3 : rm-acceleratedCompositingForAnimationEnabled: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M LayoutTests/compositing/will-change/gpu-rasterization-hint-suppresses-compositing.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 2 3 chunks +0 lines, -10 lines 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingTriggers.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
danakj
6 years, 8 months ago (2014-04-23 14:37:02 UTC) #1
Ian Vollick
On 2014/04/23 14:37:02, danakj wrote: lgtm
6 years, 8 months ago (2014-04-23 14:43:08 UTC) #2
abarth-chromium
LGTM \o/
6 years, 8 months ago (2014-04-23 18:05:35 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 8 months ago (2014-04-24 14:34:29 UTC) #4
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 8 months ago (2014-04-24 14:34:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/249423002/20001
6 years, 8 months ago (2014-04-24 14:34:51 UTC) #6
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-04-30 15:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/249423002/20001
6 years, 7 months ago (2014-04-30 15:15:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 15:16:24 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/compositing/CompositingReasonFinder.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-30 15:16:24 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-04-30 15:19:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/249423002/40001
6 years, 7 months ago (2014-04-30 15:20:11 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 16:20:39 UTC) #13
Message was sent while issue was closed.
Change committed as 172997

Powered by Google App Engine
This is Rietveld 408576698