Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2494203003: Increase inlining depth limit for AOT optimization. (Closed)

Created:
4 years, 1 month ago by Florian Schneider
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increase inlining depth limit for AOT optimization. This helps inlining more functions -- since the size limits are already much smaller than in the JIT, this does not increase overall code size in many cases, but helps performance by inlining more calls in chains of super constructors calls, super getters. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e307bc8ef0c0bb42c2a42b892cb2167613b6559a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
Flutter build_bench: +6% before: 1466.6 1471.2 1477.4 1464.9 1477.3 1468.2 1449.3 1467.3 1487.5 1447.2 === ...
4 years, 1 month ago (2016-11-11 23:16:24 UTC) #2
rmacnak
lgtm
4 years, 1 month ago (2016-11-12 00:15:45 UTC) #3
Florian Schneider
4 years, 1 month ago (2016-11-12 00:18:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e307bc8ef0c0bb42c2a42b892cb2167613b6559a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698