ios/chrome/browser/physical_web/physical_web_local_state.h - Issue 2494193002: Register Physical Web preference in Chrome's local state

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/physical_web/physical_web_local_state.h

Issue 2494193002: Register Physical Web preference in Chrome's local state (Closed)

Patch Set: switch to pure C++ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_PHYSICAL_WEB_PHYSICAL_WEB_LOCAL_STATE_H_

	6 #define IOS_CHROME_BROWSER_PHYSICAL_WEB_PHYSICAL_WEB_LOCAL_STATE_H_

	7

	8 class PrefRegistrySimple;

	9

	10 namespace physical_web {

	11

	12 // Registers local state preferences related to the Physical Web.

	13 void RegisterPrefs(PrefRegistrySimple* registry);
	rohitrao (ping after 24h) 2016/11/16 21:29:53 I just CQed a change that adds a file named physic I just CQed a change that adds a file named physical_web_prefs_registration.h. Could you move this function into that file (and perhaps rename it to RegisterPhysicalWebLocalStatePrefs()?) Sylvain, I've been omitting the namespace. Do you prefer to have it or to omit it? mattreynolds 2016/11/28 20:18:54 Done. Show quoted text On 2016/11/16 21:29:53, rohitrao wrote: > I just CQed a change that adds a file named physical_web_prefs_registration.h. > Could you move this function into that file (and perhaps rename it to > RegisterPhysicalWebLocalStatePrefs()?) Done.
	14

	15 } // namespace physical_web

	16

	17 #endif // IOS_CHROME_BROWSER_PHYSICAL_WEB_PHYSICAL_WEB_LOCAL_STATE_H_

OLD	NEW