Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2494183002: Remove some global defines and build flags. (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, oka+watch_chromium.org, creis+watch_chromium.org, yamaguchi+watch_chromium.org, nasko+codewatch_chromium.org, jam, rginda+watch_chromium.org, dglazkov+blink, mtomasz+watch_chromium.org, darin-cc_chromium.org, fukino+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some global defines and build flags. Convert image loader extension C++ checks to use OS_CHROMEOS. There are only two of these and this flag always goes with ChromeOS and is not overridable. It seems we do not get much benefit from having this be a define/buildflag, and because this is referenced from both //ui and //chrome the layering of where the flag should be but is unclear. Move use_minikin_hyphenation to a buildflag header in Blink. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2cf0a69b66582c80125579d3fa32885ee85917b3 Cr-Commit-Position: refs/heads/master@{#431680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/component_extensions_whitelist/whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/features.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/public/public_features.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
brettw
4 years, 1 month ago (2016-11-11 19:13:50 UTC) #3
sky
LGTM
4 years, 1 month ago (2016-11-11 19:21:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494183002/1
4 years, 1 month ago (2016-11-11 20:17:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 23:14:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 23:54:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cf0a69b66582c80125579d3fa32885ee85917b3
Cr-Commit-Position: refs/heads/master@{#431680}

Powered by Google App Engine
This is Rietveld 408576698