Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2494103002:
Move use_system_xcode to //build_overrides/build.gni (Closed)
|
Created:
4 years, 1 month ago by kjellander_chromium Modified:
4 years, 1 month ago CC:
chromium-reviews, erikchen Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove use_system_xcode to //build_overrides/build.gni
This makes it possible for projects that reuse Chromium's build
toolchain to use the system Xcode by setting use_system_xcode=true
in //build_overrides/build.gni
BUG=webrtc:6700, chromium:659726
TBR=brettw@chromium.org
Committed: https://crrev.com/f1e2718a3ff89c80691a50f8ea2503cbb9aa97ee
Cr-Commit-Position: refs/heads/master@{#431838}
Patch Set 1 #Patch Set 2 : Moved references into build.gni #
Total comments: 1
Messages
Total messages: 39 (20 generated)
Description was changed from ========== Move use_system_xcode to //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 ========== to ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 ==========
kjellander@chromium.org changed reviewers: + dpranke@chromium.org, thakis@chromium.org
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I think this is better than the revert in https://codereview.chromium.org/2500483002/ (which I now aborted for the moment)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm if you make it work.
But you use the hermetic toolchain on Windows, right? How does that work? On Nov 11, 2016 9:32 AM, <machenbach@chromium.org> wrote: > lgtm if you make it work. > > https://codereview.chromium.org/2494103002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I apparently only tested PS#1 from a WebRTC perspective. PS#2 is a bit uglier but passes in Chrome and WebRTC environments. Let me know if it's an acceptable solution. If not I'd appreciate if you can submit the revert in https://codereview.chromium.org/2500483002/ while working out a better solution. On 2016/11/11 14:41:08, Nico wrote: > But you use the hermetic toolchain on Windows, right? How does that work? Yes. The problem isn't with the hermetic toolchain as a feature, but that it's (currently) missing SDK 10.12 which our build requires. The current hermetic Mac toolchain currently only contains 10.10 and 10.11. > On Nov 11, 2016 9:32 AM, <mailto:machenbach@chromium.org> wrote: > > > lgtm if you make it work. > > > > https://codereview.chromium.org/2494103002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
The Windows toolchain only has one SDK at a time too. How was the 2013->2015 transition handled? Did webrtc put a different hash somewhere? Out of interest, what do you require the 10.12 SDK for? On Fri, Nov 11, 2016 at 9:46 AM, <kjellander@chromium.org> wrote: > I apparently only tested PS#1 from a WebRTC perspective. PS#2 is a bit > uglier > but passes in Chrome and WebRTC environments. Let me know if it's an > acceptable > solution. If not I'd appreciate if you can submit the revert in > https://codereview.chromium.org/2500483002/ while working out a better > solution. > > On 2016/11/11 14:41:08, Nico wrote: > > But you use the hermetic toolchain on Windows, right? How does that work? > > Yes. The problem isn't with the hermetic toolchain as a feature, but that > it's > (currently) missing SDK 10.12 which our build requires. The current > hermetic Mac > toolchain currently only contains 10.10 and 10.11. > > > On Nov 11, 2016 9:32 AM, <mailto:machenbach@chromium.org> wrote: > > > > > lgtm if you make it work. > > > > > > https://codereview.chromium.org/2494103002/ > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Chromium-reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > > > https://codereview.chromium.org/2494103002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
(I think I'd revert the hermetic toolchain for now rather than rush in a fix, fwiw, and then discuss our options and pick one without having to do it in a hurry due to things being broken.) On Fri, Nov 11, 2016 at 9:53 AM, Nico Weber <thakis@chromium.org> wrote: > The Windows toolchain only has one SDK at a time too. How was the > 2013->2015 transition handled? Did webrtc put a different hash somewhere? > > Out of interest, what do you require the 10.12 SDK for? > > On Fri, Nov 11, 2016 at 9:46 AM, <kjellander@chromium.org> wrote: > >> I apparently only tested PS#1 from a WebRTC perspective. PS#2 is a bit >> uglier >> but passes in Chrome and WebRTC environments. Let me know if it's an >> acceptable >> solution. If not I'd appreciate if you can submit the revert in >> https://codereview.chromium.org/2500483002/ while working out a better >> solution. >> >> On 2016/11/11 14:41:08, Nico wrote: >> > But you use the hermetic toolchain on Windows, right? How does that >> work? >> >> Yes. The problem isn't with the hermetic toolchain as a feature, but that >> it's >> (currently) missing SDK 10.12 which our build requires. The current >> hermetic Mac >> toolchain currently only contains 10.10 and 10.11. >> >> > On Nov 11, 2016 9:32 AM, <mailto:machenbach@chromium.org> wrote: >> > >> > > lgtm if you make it work. >> > > >> > > https://codereview.chromium.org/2494103002/ >> > > >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "Chromium-reviews" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an >> email >> > to mailto:chromium-reviews+unsubscribe@chromium.org. >> >> >> >> https://codereview.chromium.org/2494103002/ >> > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
erikchen@chromium.org changed reviewers: + erikchen@chromium.org
lgtm https://codereview.chromium.org/2494103002/diff/20001/.gn File .gn (right): https://codereview.chromium.org/2494103002/diff/20001/.gn#newcode239 .gn:239: "//build/toolchain/toolchain.gni", this line can be removed.
lgtm
The CQ bit was checked by kjellander@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2494103002/#ps20001 (title: "Moved references into build.gni")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 ========== to ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 TBR=brettw@chromium.org ==========
kjellander@chromium.org changed reviewers: + brettw@chromium.org
On 2016/11/12 05:37:00, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) TBR'ing brettw@ for the root .gn file assuming he's OK with that since I got lgtm from dpranke@. Dirk: I think you should be per-file owner of the root .gn file.
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 TBR=brettw@chromium.org ========== to ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 TBR=brettw@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 TBR=brettw@chromium.org ========== to ========== Move use_system_xcode to //build_overrides/build.gni This makes it possible for projects that reuse Chromium's build toolchain to use the system Xcode by setting use_system_xcode=true in //build_overrides/build.gni BUG=webrtc:6700,chromium:659726 TBR=brettw@chromium.org Committed: https://crrev.com/f1e2718a3ff89c80691a50f8ea2503cbb9aa97ee Cr-Commit-Position: refs/heads/master@{#431838} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f1e2718a3ff89c80691a50f8ea2503cbb9aa97ee Cr-Commit-Position: refs/heads/master@{#431838}
Message was sent while issue was closed.
Since my suggestion of "revert first, then figure out what we actually want to do here, then do that" wasn't taken up: What's the desired long-term plan here? It fairly likely isn't "webrtc stays on system xcode", is it? On Mon, Nov 14, 2016 at 1:54 AM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Patchset 2 (id:??) landed as > https://crrev.com/f1e2718a3ff89c80691a50f8ea2503cbb9aa97ee > Cr-Commit-Position: refs/heads/master@{#431838} > > https://codereview.chromium.org/2494103002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
On 2016/11/14 16:09:16, Nico wrote: > Since my suggestion of "revert first, then figure out what we actually want > to do here, then do that" wasn't taken up: What's the desired long-term > plan here? It fairly likely isn't "webrtc stays on system xcode", is it? I am also curious about this.
Message was sent while issue was closed.
On 2016/11/14 16:57:52, brettw (ping on IM after 24h) wrote: > On 2016/11/14 16:09:16, Nico wrote: > > Since my suggestion of "revert first, then figure out what we actually want > > to do here, then do that" wasn't taken up: What's the desired long-term > > plan here? It fairly likely isn't "webrtc stays on system xcode", is it? > > I am also curious about this. I thought the idea is to unblock downstream rolls with this like: https://codereview.chromium.org/2502513002/ https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12426... Though, I still need to define the variables now in V8's build_overrides for this to work - which is not optimal. We can in the downstream projects also switch to hermetic xcode in a controlled way without blocking deps rollers. Basically this particular problem is just an instance of http://crbug.com/617873 - if we had a better solution for that I assume the roll wouldn't have been blocked.
Message was sent while issue was closed.
On 2016/11/14 17:09:20, machenbach (slow) wrote: > On 2016/11/14 16:57:52, brettw (ping on IM after 24h) wrote: > > On 2016/11/14 16:09:16, Nico wrote: > > > Since my suggestion of "revert first, then figure out what we actually want > > > to do here, then do that" wasn't taken up: I didn't proceed with the revert since it seemed equally quick to just make it possible for downstream projects to set the use_system_xcode variable instead. > > > What's the desired long-term > > > plan here? It fairly likely isn't "webrtc stays on system xcode", is it? > > > > I am also curious about this. Yes, we'd love to use the hermetic toolchain. Unfortunately it doesn't work for our build right now: https://bugs.chromium.org/p/webrtc/issues/detail?id=6700#c1 ld: library not found for -lc++ clang: error: linker command failed with exit code 1 (use -v to see invocation) I incorrectly claimed we needed the 10.12 SDK in #msg13 above but it seems like it's just a library that's missing from the hermetic toolchain (since we target 10.11). > I thought the idea is to unblock downstream rolls with this like: > https://codereview.chromium.org/2502513002/ > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12426... > > Though, I still need to define the variables now in V8's build_overrides for > this to work - which is not optimal. We can in the downstream projects also > switch to hermetic xcode in a controlled way without blocking deps rollers. > > Basically this particular problem is just an instance of http://crbug.com/617873 > - if we had a better solution for that I assume the roll wouldn't have been > blocked. We'd also love to see progress in that bug.
Message was sent while issue was closed.
Chromium also links against libc++. On Tue, Nov 15, 2016 at 4:17 AM, <kjellander@chromium.org> wrote: > On 2016/11/14 17:09:20, machenbach (slow) wrote: > > On 2016/11/14 16:57:52, brettw (ping on IM after 24h) wrote: > > > On 2016/11/14 16:09:16, Nico wrote: > > > > Since my suggestion of "revert first, then figure out what we > actually > want > > > > to do here, then do that" wasn't taken up: > > I didn't proceed with the revert since it seemed equally quick to just > make it > possible for downstream projects to set the use_system_xcode variable > instead. > > > > > What's the desired long-term > > > > plan here? It fairly likely isn't "webrtc stays on system xcode", is > it? > > > > > > I am also curious about this. > > Yes, we'd love to use the hermetic toolchain. Unfortunately it doesn't > work for > our build right now: https://bugs.chromium.org/p/ > webrtc/issues/detail?id=6700#c1 > ld: library not found for -lc++ > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > > I incorrectly claimed we needed the 10.12 SDK in #msg13 above but it seems > like > it's just a library that's missing from the hermetic toolchain (since we > target > 10.11). > > > I thought the idea is to unblock downstream rolls with this like: > > https://codereview.chromium.org/2502513002/ > > > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_ > rel_ng/builds/12426/steps/generate_build_files/logs/stdout > > > > Though, I still need to define the variables now in V8's build_overrides > for > > this to work - which is not optimal. We can in the downstream projects > also > > switch to hermetic xcode in a controlled way without blocking deps > rollers. > > > > Basically this particular problem is just an instance of > http://crbug.com/617873 > > - if we had a better solution for that I assume the roll wouldn't have > been > > blocked. > > We'd also love to see progress in that bug. > > > https://codereview.chromium.org/2494103002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
