Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 2494093002: Refactor enqueuers (Closed)
Patch Set: Updated cf. comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/tool/perf.dart ('k') | tests/compiler/dart2js/compiler_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart2js_incremental/lib/caching_compiler.dart
diff --git a/pkg/dart2js_incremental/lib/caching_compiler.dart b/pkg/dart2js_incremental/lib/caching_compiler.dart
index 5582bab2098bfe0f31299e8c34adb8199440bb92..8c6357fd5cd9c620dd765eaec0b2e151ee72b1f9 100644
--- a/pkg/dart2js_incremental/lib/caching_compiler.dart
+++ b/pkg/dart2js_incremental/lib/caching_compiler.dart
@@ -35,17 +35,19 @@ Future<CompilerImpl> reuseCompiler(
environment = {};
}
CompilerImpl compiler = cachedCompiler;
+ JavaScriptBackend backend = compiler?.backend;
if (compiler == null ||
compiler.libraryRoot != libraryRoot ||
!compiler.options.hasIncrementalSupport ||
compiler.hasCrashed ||
- compiler.enqueuer.resolution.hasEnqueuedReflectiveElements ||
+ backend.mirrorsAnalysis.resolutionHandler.hasEnqueuedReflectiveElements ||
compiler.deferredLoadTask.isProgramSplit) {
if (compiler != null && compiler.options.hasIncrementalSupport) {
print('***FLUSH***');
if (compiler.hasCrashed) {
print('Unable to reuse compiler due to crash.');
- } else if (compiler.enqueuer.resolution.hasEnqueuedReflectiveElements) {
+ } else if (backend.mirrorsAnalysis.resolutionHandler
+ .hasEnqueuedReflectiveElements) {
print('Unable to reuse compiler due to dart:mirrors.');
} else if (compiler.deferredLoadTask.isProgramSplit) {
print('Unable to reuse compiler due to deferred loading.');
@@ -64,7 +66,7 @@ Future<CompilerImpl> reuseCompiler(
packageConfig: packageConfig,
options: options,
environment: environment));
- JavaScriptBackend backend = compiler.backend;
+ backend = compiler.backend;
full.Emitter emitter = backend.emitter.emitter;
@@ -83,8 +85,7 @@ Future<CompilerImpl> reuseCompiler(
// Likewise, always be prepared for runtimeType support.
// TODO(johnniwinther): Add global switch to force RTI.
compiler.enabledRuntimeType = true;
- backend.registerRuntimeType(
- compiler.enqueuer.resolution, compiler.globalDependencies);
+ backend.registerRuntimeType(compiler.enqueuer.resolution);
return compiler;
});
});
« no previous file with comments | « pkg/compiler/tool/perf.dart ('k') | tests/compiler/dart2js/compiler_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698