Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2494073002: [turbofan] Optimize ToName conversion. (Closed)

Created:
4 years, 1 month ago by Franzi
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize ToName conversion. ToName conversion, i.e., ToPropertykey() is the identify for strings and symbols. BUG=v8:5623 Committed: https://crrev.com/6d84f2d9ed8e75fa11ead51749dcbb9f31d9f838 Cr-Commit-Position: refs/heads/master@{#40924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +35 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Franzi
PTAL. Thanks, Franzi
4 years, 1 month ago (2016-11-11 12:28:54 UTC) #6
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-11 12:32:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494073002/1
4 years, 1 month ago (2016-11-11 12:33:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:05:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d84f2d9ed8e75fa11ead51749dcbb9f31d9f838
Cr-Commit-Position: refs/heads/master@{#40924}

Powered by Google App Engine
This is Rietveld 408576698