Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2494043002: [debugger,compiler] do not recompile already compiled inner functions. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger,compiler] do not recompile already compiled inner functions. GetSharedFunctionInfo will compile inner functions if we get the compile-eager hint, even if the shared function info already exists, and the function already has been compiled. This breaks suspended generator objects. R=mstarzinger@chromium.org, neis@chromium.org BUG=v8:5575 Committed: https://crrev.com/389d0dd115418a8ca62deadef0651d5a3d84de5e Cr-Commit-Position: refs/heads/master@{#40936}

Patch Set 1 #

Patch Set 2 : do not log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M src/compiler.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
A test/debugger/regress/regress-5575-1.js View 1 chunk +21 lines, -0 lines 0 comments Download
A test/debugger/regress/regress-5575-2.js View 1 chunk +21 lines, -0 lines 0 comments Download
A test/debugger/regress/regress-5575-3.js View 1 chunk +29 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Yang
4 years, 1 month ago (2016-11-11 09:33:45 UTC) #1
Michael Starzinger
LGTM.
4 years, 1 month ago (2016-11-11 10:12:08 UTC) #2
neis
lgtm now, thanks!
4 years, 1 month ago (2016-11-11 11:22:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494043002/20001
4 years, 1 month ago (2016-11-11 15:25:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 15:53:07 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/389d0dd115418a8ca62deadef0651d5a3d84de5e
Cr-Commit-Position: refs/heads/master@{#40936}

Powered by Google App Engine
This is Rietveld 408576698